[Proposal] Translate Bisq software images in the homepage #207 #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gilsanjuan, thanks for finally taking care of this! One nit: could you please un-bold the BTC price? Looks like a heavy font in all screenshots. PR:
Current:
|
|
@m52go done
Done |
|
ACK |
|
@gilsanjuan thanks again! In the future, please try to follow this style for your commit messages. In particular, capitalize first letter and use imperative tense (e.g., "optimized svg images" --> "Optimize svg images"). |
This was referenced Nov 5, 2019
m52go
pushed a commit
to m52go/bisq-website
that referenced
this pull request
Nov 28, 2019
It seems the SVGs used for screenshots on the front page did not behave consistently across OSes. Testing indicated no issues on multiple browsers on Ubuntu, but testing on macOS indicated SVG font properties were not being applied correctly. Images were PNGs before, and there was no particular need to switch to SVG, so this commit switches them back to PNG. The switch was initially made in bisq-network#278 to produce translated screenshots. SVG files remain in the repository as "source" for the PNG files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I worked 14 .svg images from Bisq software, 7 images of Offer book screen ( bisq_screen0), and 7 images of Trades( bisq_screen1). Included EN, ES, DE, FR, PT, JP, CN translations
I optimized bisq_screen0 to 59 KB, and bisq_screen2 to 38 KB.
At the end, I changed png image extension to svg for bisq_screen0 and bisq_screen1 on index.html, _includes/homepage_content.html and _includes/homepage_content_tr.html