Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix es/dao/ button "Ver más" #297

Merged
merged 1 commit into from Nov 27, 2019
Merged

Conversation

luisantoniocrag
Copy link
Contributor

2019-11-27_1604

This button will not work because it is linked to an id called #why and the section you should call has the id #porqué. I think it is better to keep everything in English so that these problems do not occur.

@m52go
Copy link
Contributor

m52go commented Nov 27, 2019

ACK

@m52go
Copy link
Contributor

m52go commented Nov 27, 2019

Thanks @luisantoniocrag, looks like translators didn't realize the id attributes weren't supposed to be translated. This is also a problem for the French translation, which I just made a PR for, if you don't mind giving it a quick review.

EDIT: nevermind, disregard, I didn't see you had already made a PR for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants