Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PGP SIGNATURE link next to download #318

Merged
merged 10 commits into from Jan 27, 2020

Conversation

RiccardoMasutti
Copy link
Contributor

Closes #317

@RiccardoMasutti
Copy link
Contributor Author

@ripcurlx what about main menu?

@m52go
Copy link
Contributor

m52go commented Dec 22, 2019

The links don't work! Just add .asc at the end of the download links. Your links are a bit different.

See:
https://deploy-preview-318--bisq-website.netlify.com/downloads/

Also I think it would be better to make the links lowercase, i.e. "PGP Signature" instead of "PGP SIGNATURE".

I think we can leave the main menus as they are, since there isn't much space there. Plus there's already a PGP signature link there anyway.

Steve Jain added 2 commits January 27, 2020 06:46
- Implement as variable in <lang>.yml file
- Correct .asc file links
@m52go
Copy link
Contributor

m52go commented Jan 27, 2020

@RiccardoMasutti updates with latest 2 commits get rid of merge conflicts and address other concerns...should be ready to merge.

@m52go m52go merged commit 402fc1c into bisq-network:master Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download page (https://bisq.network/downloads/) has a bad link to "PGP Signatures."
2 participants