Test too few inputs in fee payment

bisq-network · Jan 15, 2024 · 05dfbca · 05dfbca
1 parent 4d4c9e3
commit 05dfbca
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 0 deletions.
diff --git a/core/src/test/java/bisq/core/fee/MakerTxValidatorSanityCheckTests.java b/core/src/test/java/bisq/core/fee/MakerTxValidatorSanityCheckTests.java
@@ -23,6 +23,7 @@
 import bisq.core.provider.mempool.TxValidator;
 
 import com.google.gson.Gson;
+import com.google.gson.JsonArray;
 import com.google.gson.JsonObject;
 import com.google.gson.JsonPrimitive;
 
@@ -121,6 +122,20 @@ void checkFeeAddressBtcTestVinOrVoutNotJsonArray(String vinOrVout) throws IOExce
         assertThat(txValidator1.getStatus(), is(FeeValidationStatus.NACK_JSON_ERROR));
     }
 
+    @Test
+    void checkFeeAddressBtcNoTooFewVin() throws IOException {
+        JsonObject json = MakerTxValidatorSanityCheckTests.getValidBtcMakerFeeMempoolJsonResponse();
+        json.add("vin", new JsonArray(0));
+        assertThat(json.get("vin").getAsJsonArray().size(), is(0));
+
+        String jsonContent = new Gson().toJson(json);
+        TxValidator txValidator1 = txValidator.parseJsonValidateMakerFeeTx(jsonContent,
+                MakerTxValidatorSanityCheckTests.FEE_RECEIVER_ADDRESSES);
+
+        assertThat(txValidator1.getStatus(), is(FeeValidationStatus.NACK_JSON_ERROR));
+    }
+
+
     @Test
     void responseHasDifferentTxId() throws IOException {
         String differentTxId = "abcde971ead7d03619e3a9eeaa771ed5adba14c448839e0299f857f7bb4ec07";

diff --git a/core/src/test/java/bisq/core/fee/TakerTxValidatorSanityCheckTests.java b/core/src/test/java/bisq/core/fee/TakerTxValidatorSanityCheckTests.java
@@ -23,6 +23,7 @@
 import bisq.core.provider.mempool.TxValidator;
 
 import com.google.gson.Gson;
+import com.google.gson.JsonArray;
 import com.google.gson.JsonObject;
 import com.google.gson.JsonPrimitive;
 
@@ -121,6 +122,19 @@ void checkFeeAddressBtcTestVinOrVoutNotJsonArray(String vinOrVout) throws IOExce
         assertThat(txValidator1.getStatus(), is(FeeValidationStatus.NACK_JSON_ERROR));
     }
 
+    @Test
+    void checkFeeAddressBtcNoTooFewVin() throws IOException {
+        JsonObject json = MakerTxValidatorSanityCheckTests.getValidBtcMakerFeeMempoolJsonResponse();
+        json.add("vin", new JsonArray(0));
+        assertThat(json.get("vin").getAsJsonArray().size(), is(0));
+
+        String jsonContent = new Gson().toJson(json);
+        TxValidator txValidator1 = txValidator.parseJsonValidateMakerFeeTx(jsonContent,
+                MakerTxValidatorSanityCheckTests.FEE_RECEIVER_ADDRESSES);
+
+        assertThat(txValidator1.getStatus(), is(FeeValidationStatus.NACK_JSON_ERROR));
+    }
+
     @Test
     void responseHasDifferentTxId() throws IOException {
         String differentTxId = "abcde971ead7d03619e3a9eeaa771ed5adba14c448839e0299f857f7bb4ec07";