Skip to content

Commit

Permalink
Remove not traded assets
Browse files Browse the repository at this point in the history
- Remove Gridcoin, LitecoinZ and ZeroOneCoin
- Update getMainCryptoCurrencies and getRemovedCryptoCurrencies methods
- Update isWarmingUp method

Insufficiently traded assets:
Gridcoin (GRC): Trade amount: 0.0055 BTC, number of trades: 1

Not traded assets:
01coin (ZOC)
LitecoinZ (LTZ)
  • Loading branch information
ManfredKarrer committed Feb 18, 2019
1 parent 5d15783 commit 59920bb
Show file tree
Hide file tree
Showing 9 changed files with 26 additions and 219 deletions.
28 changes: 0 additions & 28 deletions assets/src/main/java/bisq/asset/coins/Gridcoin.java

This file was deleted.

31 changes: 0 additions & 31 deletions assets/src/main/java/bisq/asset/coins/LitecoinZ.java

This file was deleted.

39 changes: 0 additions & 39 deletions assets/src/main/java/bisq/asset/coins/ZeroOneCoin.java

This file was deleted.

3 changes: 0 additions & 3 deletions assets/src/main/resources/META-INF/services/bisq.asset.Asset
Expand Up @@ -36,14 +36,12 @@ bisq.asset.coins.EtherClassic
bisq.asset.coins.FourtyTwo
bisq.asset.coins.Fujicoin
bisq.asset.coins.GambleCoin
bisq.asset.coins.Gridcoin
bisq.asset.coins.Grin
bisq.asset.coins.Horizen
bisq.asset.coins.IdaPay
bisq.asset.coins.Iridium
bisq.asset.coins.Kekcoin
bisq.asset.coins.Litecoin
bisq.asset.coins.LitecoinZ
bisq.asset.coins.Lytix
bisq.asset.coins.Mask
bisq.asset.coins.Mile
Expand Down Expand Up @@ -78,7 +76,6 @@ bisq.asset.coins.Zcash
bisq.asset.coins.Zcoin
bisq.asset.coins.ZelCash
bisq.asset.coins.Zero
bisq.asset.coins.ZeroOneCoin
bisq.asset.tokens.AugmintEuro
bisq.asset.tokens.DaiStablecoin
bisq.asset.tokens.EtherStone
Expand Down
27 changes: 0 additions & 27 deletions assets/src/test/java/bisq/asset/coins/GridcoinTest.java

This file was deleted.

43 changes: 0 additions & 43 deletions assets/src/test/java/bisq/asset/coins/LitecoinZTest.java

This file was deleted.

46 changes: 0 additions & 46 deletions assets/src/test/java/bisq/asset/coins/ZeroOneCoinTest.java

This file was deleted.

4 changes: 3 additions & 1 deletion core/src/main/java/bisq/core/locale/CurrencyUtil.java
Expand Up @@ -132,7 +132,6 @@ public static List<CryptoCurrency> getMainCryptoCurrencies() {
result.add(new CryptoCurrency("DASH", "Dash"));
result.add(new CryptoCurrency("DCR", "Decred"));
result.add(new CryptoCurrency("ETH", "Ether"));
result.add(new CryptoCurrency("GRC", "Gridcoin"));
result.add(new CryptoCurrency("GRIN", "Grin"));
result.add(new CryptoCurrency("LTC", "Litecoin"));
result.add(new CryptoCurrency("XMR", "Monero"));
Expand All @@ -152,6 +151,9 @@ public static List<CryptoCurrency> getRemovedCryptoCurrencies() {
currencies.add(new CryptoCurrency("SC", "SpaceCash"));
currencies.add(new CryptoCurrency("PPI", "PiedPiper Coin"));
currencies.add(new CryptoCurrency("PEPECASH", "Pepe Cash"));
currencies.add(new CryptoCurrency("GRC", "Gridcoin"));
currencies.add(new CryptoCurrency("LTZ", "LitecoinZ"));
currencies.add(new CryptoCurrency("ZOC", "01coin"));
return currencies;
}

Expand Down
Expand Up @@ -141,7 +141,7 @@ public void onAllServicesInitialized() {
"\n\n" + newAssets.toString() +
"\n\n" + sufficientlyTraded.toString();
// Utilities.copyToClipboard(result);
log.debug(result);
log.info(result);
}

private boolean isWarmingUp(String code) {
Expand Down Expand Up @@ -194,6 +194,28 @@ private boolean isWarmingUp(String code) {
newlyAdded.add("WEB");
newlyAdded.add("WRKZ");

// v0.9.3 - nothing added, was hotfix

// v0.9.4 (Feb 18 2019)
newlyAdded.add("ADE");
newlyAdded.add("ASK");
newlyAdded.add("AEUR");
newlyAdded.add("AUS");
newlyAdded.add("CASH2");
newlyAdded.add("DARX");
newlyAdded.add("CRDS");
newlyAdded.add("CRCL");
newlyAdded.add("DAI");
newlyAdded.add("ONION");
newlyAdded.add("FJC");
newlyAdded.add("LYTX");
newlyAdded.add("MILE");
newlyAdded.add("PRSN");
newlyAdded.add("TUSD");
newlyAdded.add("USDC");
newlyAdded.add("VXV");
newlyAdded.add("ZEL");

return newlyAdded.contains(code);
}
}

4 comments on commit 59920bb

@MarkLTZ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @ManfredKarrer, please re-add listing for LitecoinZ (LTZ)

LitecoinZ was just added on master branch by commit be257da but a new release of BisQ including this cois has never been released: https://github.com/bisq-network/bisq/releases/tag/v0.9.3 thus it's normal that today people has not yet traded it.

Regards,
Mark

@curvedinf
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, I am a user who has been waiting on LitecoinZ integration in Bisq. I can confirm it was never released, and if it were I would be trading on it.

@ManfredKarrer
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes just fixed it, was missing in release note draft, so I incorrectly removed it. Is already added again. Be aware that if not traded in 3 months period it gets removed in upcoming release....

@MarkLTZ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot

Please sign in to comment.