Skip to content

Commit

Permalink
Merge pull request #3217 from erciccione/squash
Browse files Browse the repository at this point in the history
Add "squash commits" to contributor's workflow
  • Loading branch information
ripcurlx committed Sep 6, 2019
2 parents 118d33a + 8b2ecb4 commit 660f130
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ All Bisq contributors submit changes via pull requests. The workflow is as follo
- Fork the repository
- Create a topic branch from the `master` branch
- Commit patches
- Squash redundant or unnecessary commits
- Submit a pull request from your topic branch back to the `master` branch of the main repository

Pull requests should be focused on a single change. Do not mix, for example, refactorings with a bug fix or implementation of a new feature. This practice makes it easier for fellow contributors to review each pull request on its merits and and to give a clear ACK/NACK (see below).
Expand Down Expand Up @@ -73,6 +74,10 @@ https://help.github.com/articles/signing-commits-with-gpg/ for instructions.

The [.editorconfig](.editorconfig) settings in this repository ensure consistent management of whitespace, line endings and more. Most modern editors support it natively or with plugin. See http://editorconfig.org for details. See also [bisq-network/style#10](https://github.com/bisq-network/style/issues/10).

### Keep the git history clean

It's very important to keep the git history clear, light and easily browsable. This means contributors must make sure their pull requests include only meaningful commits (if they are redundant or were added after a review, they should be removed) and _no merge commits_.

### Additional style guidelines

See the issues in the [bisq-network/style](https://github.com/bisq-network/style/issues) repository.
Expand Down

0 comments on commit 660f130

Please sign in to comment.