Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional information for security deposit #1216

Closed
ripcurlx opened this issue Jan 18, 2018 · 28 comments
Closed

Add additional information for security deposit #1216

ripcurlx opened this issue Jan 18, 2018 · 28 comments
Assignees

Comments

@ripcurlx
Copy link
Member

ripcurlx commented Jan 18, 2018

At some screens we don't explain the reasoning behind the security deposit (e.g. Create offer). On all screens where we require the user to accept or change a security deposit we should display a information icon, that explains the reasoning behind it and what value a user should go for.

Create offer to sell
Create offer to sell

@ripcurlx ripcurlx self-assigned this Feb 6, 2018
@ripcurlx
Copy link
Member Author

ripcurlx commented Feb 8, 2018

In the buyer screen it could look something like this:
security deposit info

@ripcurlx
Copy link
Member Author

ripcurlx commented Feb 8, 2018

Actually on this screen I think we should write:

Set your security deposit
Security deposit: [0.01 BTC]

instead of:

Set buyer's security deposit
Security deposit for BTC buyer: [0.01 BTC]

I don't think it makes it easier for the user to understand what this security deposit is all about by talking about the user in the third person IMO.

@ripcurlx
Copy link
Member Author

ripcurlx commented Feb 9, 2018

Here's an updated design for this screen (different text and pop over)
security deposit info

@mrosseel
Copy link
Member

mrosseel commented Feb 9, 2018

looks good, some suggestions:

  • is it 'might' result or 'will' result?
  • propose to rephrase to 'result in losing your security deposit' - sounds a bit less threatening

@ripcurlx
Copy link
Member Author

ripcurlx commented Feb 9, 2018

I wasn't sure if you'll loose the security deposit in any case you cancel an ongoing trade.
@cbeams Is it correct that you'll loose the security deposit if you don't complete an ongoing trade?
security deposit info
I also just recognized that we only show the buyer deposit to the seller in the confirmation screen. We also don't show the user if this is the default deposit or if the trader has set the deposit to the minimum value. Maybe we should think about warning the user in this case like in following screen:
warn user for low security deposit

@ripcurlx
Copy link
Member Author

ripcurlx commented Feb 9, 2018

And here is the version for creating a sell offer:
security deposit seller

@mrosseel
Copy link
Member

mrosseel commented Feb 9, 2018 via email

@ripcurlx
Copy link
Member Author

ripcurlx commented Feb 9, 2018

Thanks for pointing out the typo! I'm also not sure if we should talk about "canceling a trade" as there is no real "cancel" button, but more a not following of the trade protocol. Not following the trade protocol on the other hand sounds very complicated to me and I would immediately be afraid, that I could lose my deposit if I'm doing little mistakes.

@ripcurlx
Copy link
Member Author

ripcurlx commented Feb 9, 2018

Maybe we should add the security deposit information already in the take offer screen, if a buy offer is taken? Of course it's not really a payment information - maybe it needs it's own section. Or we add an info field only in the case if the security deposit is below the default.
seller security deposit warning

@ripcurlx
Copy link
Member Author

ripcurlx commented Feb 9, 2018

Or if we don't want trades to be taken, that have a security deposit that is below the default we could just add a warning bar 😉. Is there a good reason to change the security deposit at all? If the trade is below the default value than this might be the case, but do we really have trades that are below 0.01 BTC?
warning bar

@cbeams
Copy link
Member

cbeams commented Feb 9, 2018

I wasn't sure if you'll loose the security deposit in any case you cancel an ongoing trade.
@cbeams Is it correct that you'll loose the security deposit if you don't complete an ongoing trade?

That may happen depending on the circumstances and details of the case. I'd leave it out here for that reason.

But perhaps more importantly, I'd leave it out because it's irrelevant and confusing to talk about it here at all. In the screenshot shown at #1216 (comment), the maker-as-seller is specifying the security deposit that the buyer must pay in order to take this offer. Telling the seller that they will lose their security deposit if the cancel after the trade is taken is a non-sequitur here; I mean, even if it were perfectly true, it doesn't have anything to do with the decision that the seller needs to make here, which is all about the buyer's security deposit, not their own.

Likewise, I'd kill the note about the security deposit being returned after the trade completes. That is again true enough, but irrelevant in this context.

Also, it's "lose" your security deposit not "loose"—this is a common error, even for native speakers.

I really like the way the hover looks by the way, with regard to color, iconography and slider!

@cbeams
Copy link
Member

cbeams commented Feb 10, 2018

By the way, @ripcurlx, I'd be happy to chat about this topic sometime next week. Real-time discussion might be most efficient in sorting some of this stuff out. Just let me know if you'd like to do that.

@ripcurlx
Copy link
Member Author

@cbeams and @ManfredKarrer: Yes, maybe it would be best to discuss everything regrading the security deposit in a quick call today. Would 6pm (CET) work for you guys?

@cbeams
Copy link
Member

cbeams commented Feb 12, 2018 via email

@ManfredKarrer
Copy link
Member

@ripcurlx
I like the slider!!!!

There is still some missing context:
Only the buyers security deposit can be set because the buyer can "cancel" the trade (not a term we should use - better: not follow the trade protocol) in case the btc price has move more as he would lose from the deposit. E.g. you make a buy offer with 1 btc for 10 000. next day price is 9000. if u continue you pay 1000 usd more as new market price. if you "cancel" by not transferring fiat/altcoin you lose deposit. if deposit is < 1000 USD then its economically reasonable to do that.
We had such cases and to prevent that we leave it to the maker to set the deposit. We cannot avoid all cases as volatility can be very high specially with altcoins. But it can be also seen as a max. loss for time of high volatility. The taker cannot do much as he only release when received the fiat/alt, he cannot "cancel", thats why the sellers deposit is fixed an rather low.

I think the deposit should not be shown in the payment method as that is the users payment method (he can have multiple - then there is a dropdown).
If we show it in the main screen i would show it at the price section. In older versions i think we had an extra section with that, but i removed it as it was too much info. But open to add it again. Info is important as otherwise nobody understands it.

@ManfredKarrer
Copy link
Member

ManfredKarrer commented Feb 12, 2018

Re: warning if outside of recommendation:
I am not sure if a warning is good as it is reasonable to set it in times of high or low volatility.
Maybe better to signal if its default or custom set? Maybe just add "(default)" if so? Or use the slider as well so show in which range it is?

@ManfredKarrer
Copy link
Member

A high deposit means more security for seller. A low deposit means less money locked up for buyer. A maker as seller who wants to attract buyers can set it low, taking more risk of cancellations.

@ManfredKarrer
Copy link
Member

I think we should use the volatility alone and remove the option that the user can set it. See #1346

@ripcurlx
Copy link
Member Author

Yes, I would also prefer a solution, where we don't have to educate the user about the correct usage.

@ripcurlx
Copy link
Member Author

This issue is blocked until the automatic deposit setting is implemented.

@ManfredKarrer
Copy link
Member

Btw. We should change the defautl sec. deposit to a % value based on the trade amount. That wooudl reflect then the volatility. E.g. if you expect that the BTC price will go up or down 5-10% then you should set the deposit to that % value. Default might be about 10% but should be delivered by a service anyway.

@stale
Copy link

stale bot commented Jan 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

1 similar comment
@stale
Copy link

stale bot commented Apr 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Apr 18, 2019
@stale
Copy link

stale bot commented Apr 25, 2019

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Apr 25, 2019
@ripcurlx
Copy link
Member Author

Still relevant.

@ripcurlx ripcurlx reopened this Apr 25, 2019
@stale stale bot removed was:dropped labels Apr 25, 2019
@ghost
Copy link

ghost commented Apr 25, 2019

I profit from this thread.
It would be nice if the security deposit could reflect in some way in the avatar.
eg the avatar being replaced by a horizontal bar, with a cursor showing how high is the deposit.
Atm, the avatar conveys 0 information by itself, while it could be. That's a bit a pity.

@stale
Copy link

stale bot commented Jul 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Jul 24, 2019
@stale
Copy link

stale bot commented Jul 31, 2019

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants