Same onion address appearing as multiple peers #1703
Assignees
Labels
Comments
|
ah ah ... I suspected it. Thanks for the return. |
|
Yes, I was using wifi. |
|
@arunasurya Oh, there seems to be a rare bug. We got that reported in the past form another user as well. I never could reproduce it and did not found any suspicious in the code, but will put it on my todo list to re-check it. |
|
It's a rarely reported thing, but I'm not sure this means the thing itself is rare. |
|
Thank you for your responses. I will close the issue now since it has been noted. |
|
We can leave that open until it is fixed. |
|
@HarryMacfinned Ah good to know. I will take it with higher prio. Maybe its one reason for failed tx broadcasts. If the app is connected to the same btc node multiple times it has a low redundancy. |
|
anyway, I have never seen duplicates in the P2P onion list. So I guess the checks are not the same for BTC peers or for P2P peers. |
|
Found the issue in BitcoinJ and fixed it. |
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Dec 20, 2018
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Dec 20, 2018
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Dec 20, 2018
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Dec 20, 2018
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Dec 20, 2018
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Dec 20, 2018
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Dec 20, 2018
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Jan 2, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Jan 3, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Jan 3, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Jan 3, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Jan 3, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Jan 3, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Jan 3, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Jan 3, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Jan 4, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Jan 4, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Jan 4, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Jan 21, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Jan 21, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Jan 22, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Feb 5, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Feb 12, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to oscarguindzberg/bitcoinj
that referenced
this issue
Feb 12, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@05e675e
oscarguindzberg
pushed a commit
to bisq-network/bitcoinj
that referenced
this issue
Apr 10, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick 34461fe
oscarguindzberg
pushed a commit
to bisq-network/bitcoinj
that referenced
this issue
Apr 10, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick 34461fe PeerGroup.triggerConnectionsJob: Remove isAlreadyAdded() check because it is not necessary. Cherry pick 3185434 PeerGroup.addInactive(): Remove isAlreadyAdded() check because it is not necessary. Cherry pick 7dfab73
oscarguindzberg
pushed a commit
to bisq-network/bitcoinj
that referenced
this issue
Apr 10, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick 34461fe PeerGroup.triggerConnectionsJob: Remove isAlreadyAdded() check because it is not necessary. Cherry pick 3185434 PeerGroup.addInactive(): Remove isAlreadyAdded() check because it is not necessary. Cherry pick 7dfab73 PeerGroup.handlePeerDeath(): check isAlreadyAdded() before calling inactives.offer(address). Cherry pick de6ca8b PeerGroup.isAlreadyAdded(): refactor to ignore metadata and inline method because it is only used once. Cherry pick f790821
bodymindarts
pushed a commit
to bodymindarts/bitcoinj
that referenced
this issue
Sep 4, 2019
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick bisq-network@34461fe PeerGroup.triggerConnectionsJob: Remove isAlreadyAdded() check because it is not necessary. Cherry pick bisq-network@3185434 PeerGroup.addInactive(): Remove isAlreadyAdded() check because it is not necessary. Cherry pick bisq-network@7dfab73 PeerGroup.handlePeerDeath(): check isAlreadyAdded() before calling inactives.offer(address). Cherry pick bisq-network@de6ca8b PeerGroup.isAlreadyAdded(): refactor to ignore metadata and inline method because it is only used once. Cherry pick bisq-network@f790821
oscarguindzberg
pushed a commit
to bisq-network/bitcoinj
that referenced
this issue
May 16, 2020
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick 34461fe PeerGroup.triggerConnectionsJob: Remove isAlreadyAdded() check because it is not necessary. Cherry pick 3185434 PeerGroup.addInactive(): Remove isAlreadyAdded() check because it is not necessary. Cherry pick 7dfab73 PeerGroup.handlePeerDeath(): check isAlreadyAdded() before calling inactives.offer(address). Cherry pick de6ca8b PeerGroup.isAlreadyAdded(): refactor to ignore metadata and inline method because it is only used once. Cherry pick f790821
oscarguindzberg
pushed a commit
to bisq-network/bitcoinj
that referenced
this issue
May 16, 2020
The inactives collection contained duplicated peerAddresses after connection loss and reconnect. We add a check to see if the to-get-added peerAddress is not already in the collection and only add it if it is absent. This problem was not discovered when using the public network as the chance that same peerAddress get reported is pretty low. But with our provided nodes we got frequently duplicates. Fixes bisq-network/bisq#1703 Cherry-pick 34461fe PeerGroup.triggerConnectionsJob: Remove isAlreadyAdded() check because it is not necessary. Cherry pick 3185434 PeerGroup.addInactive(): Remove isAlreadyAdded() check because it is not necessary. Cherry pick 7dfab73 PeerGroup.handlePeerDeath(): check isAlreadyAdded() before calling inactives.offer(address). Cherry pick de6ca8b PeerGroup.isAlreadyAdded(): refactor to ignore metadata and inline method because it is only used once. Cherry pick f790821
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When setting up a trade a few days ago, I got the same .onion address that appeared as multiple peers.
If it is only one peer, it should appear as one item on the list. If there are multiple peers, they should have separate .onion addresses.
The text was updated successfully, but these errors were encountered: