Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Currency and Trading account error #1753

Closed
fedegrc opened this issue Oct 5, 2018 · 3 comments
Closed

Default Currency and Trading account error #1753

fedegrc opened this issue Oct 5, 2018 · 3 comments
Assignees
Milestone

Comments

@fedegrc
Copy link

fedegrc commented Oct 5, 2018

Issued reproduced with two o more accounts with different currencies.

Steps to reproduce:

  1. "Buy bitcoin" tab
  2. "Create new offer to buy BTC with USD"
  3. Select a Trading account that is not USD
  4. Cancel the offer by clicking the x or "Cancel"
  5. "Create new offer to buy BTC with USD"
    At this point, the "Trading account" and "Currency" shoud be USD in the "Create offer" tab, but is not. This could produce a mistake we create a new offer.

Same issue in "Sell bitcoint" tab.

@ripcurlx
Copy link
Member

@fedegrc Can you reproduce this with 0.9.0? I just tried it and it works as you are expecting.

@fedegrc
Copy link
Author

fedegrc commented Dec 13, 2018

I just tried it with version 0.9.1 and it works as expected if both Trading accounts allow only one Currency. If you have two accounts and one of them allow two or more currencies, you will be able to reproduce the issue.

Steps to reproduce:

We have the following two accounts:

Account 1:

  • Trading account: Zelle
  • Currency: US Dollar (USD)

Account 2:

  • Trading account: Revolut
  • Currency: Euro (EUR) & US Dollar (USD)

Then, we proceed with these steps:

  1. Go to "BUY BTC" section
  2. Filter by currency: "USD - US Dollar"
  3. Filter by payment method: "Zelle (ClearXchange)"
  4. Click "CREATE NEW OFFER TO BUY BTC WITH USD"
  5. Trading account: "Revolut"
  6. Currency: "Euro (EUR)"
  7. Cancel the offer by clicking the x or "Cancel"
  8. "CREATE NEW OFFER TO BUY BTC WITH USD"

At this point, you will see that the "Trading account" is Revolut (which is ok) and the "Currency" is "Euro EUR" (shoud be USD).

@ManfredKarrer ManfredKarrer added this to the v0.9.4 milestone Jan 18, 2019
@ripcurlx
Copy link
Member

@fedegrc I was able to re-produce it based on your steps in 0.9.3 as well. I'm working on a fix right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants