Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maker errors with 'Insufficient money', Taker errors with 'deposit is null' and timeout #2293

Closed
lacksfish opened this issue Jan 20, 2019 · 11 comments
Closed

Maker errors with 'Insufficient money', Taker errors with 'deposit is null' and timeout #2293

lacksfish opened this issue Jan 20, 2019 · 11 comments
Labels
a:bug in:trade-process is:critical https://bisq.wiki/Critical_bug is:priority PR or issue marked with this label is up for compensation

Comments

@lacksfish
Copy link

lacksfish commented Jan 20, 2019 •
edited
Loading

Am testing Bisq locally on regtest, and ran across this odd error.
Perhaps somebody can provide some insight?

Maker is buying Bitcoin.
Maker debug log:

...
INFO  [2019-01-20 19:11:11,056] org.bitcoinj.wallet.Wallet: Estimated balance is now: 0.4704626 BTC
INFO  [2019-01-20 19:11:11,057] org.bitcoinj.wallet.WalletFiles: Saving wallet; last seen block is height 632, date 2019-01-20T19:00:57Z, hash 270fb0fb570f8c28eb7af36d73fdcc603ea31ca756ae99e1372751e7bf345686
INFO  [2019-01-20 19:11:11,061] org.bitcoinj.wallet.WalletFiles: Save completed in 4.298 ms
INFO  [2019-01-20 19:11:11,062] bisq.core.btc.wallet.BtcWalletService: swap addressEntry with address mmz3jCcjdEXPQSneT8yhmn6DW17e5HRrEM and offerId 5c2638ac-58ca-42b5-b809-33364417efac from context OFFER_FUNDING to available
INFO  [2019-01-20 19:11:11,062] bisq.common.taskrunner.TaskRunner: Run task: AddToOfferBook
INFO  [2019-01-20 19:11:11,072] bisq.common.taskrunner.TaskRunner: Run task: ValidateOffer
INFO  [2019-01-20 19:11:11,073] bisq.common.taskrunner.TaskRunner: Run task: CreateMakerFeeTx
INFO  [2019-01-20 19:11:11,078] org.bitcoinj.wallet.WalletFiles: Saving wallet; last seen block is height 632, date 2019-01-20T19:00:57Z, hash 270fb0fb570f8c28eb7af36d73fdcc603ea31ca756ae99e1372751e7bf345686
INFO  [2019-01-20 19:11:11,082] org.bitcoinj.wallet.WalletFiles: Save completed in 4.562 ms
INFO  [2019-01-20 19:11:11,085] org.bitcoinj.wallet.WalletFiles: Saving wallet; last seen block is height 632, date 2019-01-20T19:00:57Z, hash 270fb0fb570f8c28eb7af36d73fdcc603ea31ca756ae99e1372751e7bf345686
INFO  [2019-01-20 19:11:11,092] org.bitcoinj.wallet.WalletFiles: Save completed in 6.917 ms
INFO  [2019-01-20 19:11:11,092] bisq.core.btc.wallet.TradeWalletService: reservedFundsForOffer 0.01
INFO  [2019-01-20 19:11:11,092] bisq.core.btc.wallet.TradeWalletService: tradingFee 0.000799
INFO  [2019-01-20 19:11:11,092] bisq.core.btc.wallet.TradeWalletService: txFee 0.00006
INFO  [2019-01-20 19:11:11,092] org.bitcoinj.wallet.Wallet: Completing send tx with 2 outputs totalling 0.010799 BTC and a fee of 0.00 BTC/kB
INFO  [2019-01-20 19:11:11,092] org.bitcoinj.wallet.Wallet:   with 0.0566036 BTC change
INFO  [2019-01-20 19:11:11,094] org.bitcoinj.wallet.Wallet:   with a fee of 0.00014778 BTC/kB, 0.00006 BTC for 406 bytes
INFO  [2019-01-20 19:11:11,094] org.bitcoinj.wallet.Wallet:   completed:   d3f762ea71e5a658075cd6ac358abc2a2e2cf083fdf859a660868e88221d6600
     in   PUSHDATA(71)[30440220068780534de737b4805899055cd1f6162dc328261a5aaf563cf5b90549d0a72a0220779a3da4a429ac1b850860b9834a78904923c518f467110c0b4b99ed82c8ec6a01] PUSHDATA(33)[0235b17424418424aec8d57c0e402bd8819aadafbf2b3ff476252e5a94bf693c79] 0.01 BTC (1000000)
          outpoint:4428f0178221505e3347bd583ae8048c2dcacd4f66947c521f96b59a6abc330d:1 hash160:351913224d332b0d0f7feeca2eeb527d03751649
     in   PUSHDATA(71)[304402201d9ab15307ee8bcb594fd67b7027c48f21a21282876d92baee53ff1ed51ac8100220379e9cc0e84fffae385e4618adfc1a199c6a77e5c6307cf8b1cf908b29b83de901] PUSHDATA(33)[02abf2d5ddfcf15282173d88f502cd39b7f5f1bf0e5d5e9096da034c4316291c1b] 0.0574626 BTC (5746260)
          outpoint:36cef1211af74a58b4c50b449426a29f5d85e414daf34507aad7a44c9bcae392:2 hash160:c132a9d9b620882dd4182153ab7fc03ba8f5a543
     out  DUP HASH160 PUSHDATA(20)[4f160310cfefbedeff9190a47d3db6401a6784d2] EQUALVERIFY CHECKSIG 0.000799 BTC (79900) ScriptPubKey: 76a9144f160310cfefbedeff9190a47d3db6401a6784d288ac Address:mnj83dM6SAFWadbwQXfAPojGovEerZC5FJ 
     out  DUP HASH160 PUSHDATA(20)[2a2d30d0d016500b5c4040954eaf407f5deb587f] EQUALVERIFY CHECKSIG 0.01 BTC (1000000) ScriptPubKey: 76a9142a2d30d0d016500b5c4040954eaf407f5deb587f88ac Address:mjMxp1p83JSSHe87gVYACZE8tHmfMzGSCy 
     out  DUP HASH160 PUSHDATA(20)[c6fb1648dd55510588721c08cf0393f16037f475] EQUALVERIFY CHECKSIG 0.0566036 BTC (5660360) ScriptPubKey: 76a914c6fb1648dd55510588721c08cf0393f16037f47588ac Address:myf4ssSYDdkc8CYXwhWWrUSoFBr2MCMs31 
     fee  0.00006 BTC for 406 bytes (14 Satoshi/Byte)
     prps USER_PAYMENT

INFO  [2019-01-20 19:11:11,095] bisq.core.btc.wallet.WalletService: 
tradingFeeTx:
  d3f762ea71e5a658075cd6ac358abc2a2e2cf083fdf859a660868e88221d6600
     in   PUSHDATA(71)[30440220068780534de737b4805899055cd1f6162dc328261a5aaf563cf5b90549d0a72a0220779a3da4a429ac1b850860b9834a78904923c518f467110c0b4b99ed82c8ec6a01] PUSHDATA(33)[0235b17424418424aec8d57c0e402bd8819aadafbf2b3ff476252e5a94bf693c79] 0.01 BTC (1000000)
          outpoint:4428f0178221505e3347bd583ae8048c2dcacd4f66947c521f96b59a6abc330d:1 hash160:351913224d332b0d0f7feeca2eeb527d03751649
     in   PUSHDATA(71)[304402201d9ab15307ee8bcb594fd67b7027c48f21a21282876d92baee53ff1ed51ac8100220379e9cc0e84fffae385e4618adfc1a199c6a77e5c6307cf8b1cf908b29b83de901] PUSHDATA(33)[02abf2d5ddfcf15282173d88f502cd39b7f5f1bf0e5d5e9096da034c4316291c1b] 0.0574626 BTC (5746260)
          outpoint:36cef1211af74a58b4c50b449426a29f5d85e414daf34507aad7a44c9bcae392:2 hash160:c132a9d9b620882dd4182153ab7fc03ba8f5a543
     out  DUP HASH160 PUSHDATA(20)[4f160310cfefbedeff9190a47d3db6401a6784d2] EQUALVERIFY CHECKSIG 0.000799 BTC (79900) ScriptPubKey: 76a9144f160310cfefbedeff9190a47d3db6401a6784d288ac Address:mnj83dM6SAFWadbwQXfAPojGovEerZC5FJ 
     out  DUP HASH160 PUSHDATA(20)[2a2d30d0d016500b5c4040954eaf407f5deb587f] EQUALVERIFY CHECKSIG 0.01 BTC (1000000) ScriptPubKey: 76a9142a2d30d0d016500b5c4040954eaf407f5deb587f88ac Address:mjMxp1p83JSSHe87gVYACZE8tHmfMzGSCy 
     out  DUP HASH160 PUSHDATA(20)[c6fb1648dd55510588721c08cf0393f16037f475] EQUALVERIFY CHECKSIG 0.0566036 BTC (5660360) ScriptPubKey: 76a914c6fb1648dd55510588721c08cf0393f16037f47588ac Address:myf4ssSYDdkc8CYXwhWWrUSoFBr2MCMs31 
     fee  0.00006 BTC for 406 bytes (14 Satoshi/Byte)
     prps USER_PAYMENT

INFO  [2019-01-20 19:11:11,095] org.bitcoinj.core.TransactionBroadcast: Waiting for 1 peers required for broadcast, we have 1 ...
INFO  [2019-01-20 19:11:11,095] org.bitcoinj.core.TransactionBroadcast: broadcastTransaction: We have 1 peers, adding d3f762ea71e5a658075cd6ac358abc2a2e2cf083fdf859a660868e88221d6600 to the memory pool
INFO  [2019-01-20 19:11:11,095] org.bitcoinj.core.TransactionBroadcast: Sending to 1 peers, will wait for 0, sending to: [127.0.0.1]:18444
INFO  [2019-01-20 19:11:11,095] org.bitcoinj.wallet.Wallet: Received a pending transaction d3f762ea71e5a658075cd6ac358abc2a2e2cf083fdf859a660868e88221d6600 that spends 0.0674626 BTC from our own wallet, and sends us 0.0666036 BTC
INFO  [2019-01-20 19:11:11,095] org.bitcoinj.wallet.Wallet: commitTx of d3f762ea71e5a658075cd6ac358abc2a2e2cf083fdf859a660868e88221d6600
INFO  [2019-01-20 19:11:11,095] org.bitcoinj.wallet.Wallet:   marked 4428f0178221505e3347bd583ae8048c2dcacd4f66947c521f96b59a6abc330d:1 as spent by d3f762ea71e5a658075cd6ac358abc2a2e2cf083fdf859a660868e88221d6600
INFO  [2019-01-20 19:11:11,095] org.bitcoinj.wallet.Wallet:   4428f0178221505e3347bd583ae8048c2dcacd4f66947c521f96b59a6abc330d prevtx <-unspent ->spent
INFO  [2019-01-20 19:11:11,095] org.bitcoinj.wallet.Wallet:   marked 36cef1211af74a58b4c50b449426a29f5d85e414daf34507aad7a44c9bcae392:2 as spent by d3f762ea71e5a658075cd6ac358abc2a2e2cf083fdf859a660868e88221d6600
INFO  [2019-01-20 19:11:11,095] org.bitcoinj.wallet.Wallet: ->pending: d3f762ea71e5a658075cd6ac358abc2a2e2cf083fdf859a660868e88221d6600
INFO  [2019-01-20 19:11:11,095] org.bitcoinj.wallet.Wallet: Estimated balance is now: 0.4696036 BTC
INFO  [2019-01-20 19:11:11,096] org.bitcoinj.wallet.WalletFiles: Saving wallet; last seen block is height 632, date 2019-01-20T19:00:57Z, hash 270fb0fb570f8c28eb7af36d73fdcc603ea31ca756ae99e1372751e7bf345686
INFO  [2019-01-20 19:11:11,104] org.bitcoinj.wallet.WalletFiles: Save completed in 8.293 ms
INFO  [2019-01-20 19:11:11,105] bisq.core.btc.wallet.BtcWalletService: swap addressEntry with address mmz3jCcjdEXPQSneT8yhmn6DW17e5HRrEM and offerId b7f55bca-f193-4c4a-a644-8c5444432253 from context OFFER_FUNDING to available
INFO  [2019-01-20 19:11:11,106] bisq.common.taskrunner.TaskRunner: Run task: AddToOfferBook
INFO  [2019-01-20 19:11:22,355] bisq.core.provider.price.PriceFeedService: request from provider http://174.138.104.137:8080/ 64.099 sec. after last request
INFO  [2019-01-20 19:11:23,746] bisq.core.provider.price.PriceFeedService: Received new MarketPrice(currencyCode=USD, price=3536.62, timestampSec=1548011445694, isExternallyProvidedPrice=true) from provider http://174.138.104.137:8080/ after 1.391 sec.
INFO  [2019-01-20 19:11:38,976] bisq.core.offer.OpenOfferManager: Received OfferAvailabilityRequest from localhost:5555 with offerId b7f55bca-f193-4c4a-a644-8c5444432253 and uid 791273bd-0233-4c3e-b3df-56f5669dfcae
INFO  [2019-01-20 19:11:38,976] bisq.core.offer.OpenOfferManager: Send OfferAvailabilityResponse with offerId b7f55bca-f193-4c4a-a644-8c5444432253 and uid 0a534a89-0b4b-4a4d-8542-e369b008114e to peer localhost:5555
INFO  [2019-01-20 19:11:38,978] bisq.core.offer.OpenOfferManager: Send AckMessage for OfferAvailabilityRequest to peer localhost:5555 with offerId b7f55bca-f193-4c4a-a644-8c5444432253 and sourceUid 791273bd-0233-4c3e-b3df-56f5669dfcae
INFO  [2019-01-20 19:11:38,980] bisq.core.offer.OpenOfferManager: OfferAvailabilityResponse arrived at peer: offerId=b7f55bca-f193-4c4a-a644-8c5444432253; uid=0a534a89-0b4b-4a4d-8542-e369b008114e
INFO  [2019-01-20 19:11:39,043] bisq.core.offer.OpenOfferManager: Received AckMessage for OfferAvailabilityResponse with offerId b7f55bca-f193-4c4a-a644-8c5444432253 and uid 0a534a89-0b4b-4a4d-8542-e369b008114e
INFO  [2019-01-20 19:11:39,043] bisq.core.offer.OpenOfferManager: AckMessage for OfferAvailabilityRequest arrived at takersNodeAddress localhost:5555. offerId=b7f55bca-f193-4c4a-a644-8c5444432253, sourceUid=791273bd-0233-4c3e-b3df-56f5669dfcae
INFO  [2019-01-20 19:12:25,356] bisq.core.provider.price.PriceFeedService: request from provider http://174.138.104.137:8080/ 63.001 sec. after last request
INFO  [2019-01-20 19:12:26,498] bisq.core.provider.price.PriceFeedService: Received new MarketPrice(currencyCode=USD, price=3537.13, timestampSec=1548011535535, isExternallyProvidedPrice=true) from provider http://174.138.104.137:8080/ after 1.142 sec.
INFO  [2019-01-20 19:12:55,831] bisq.core.offer.OpenOfferManager: Received OfferAvailabilityRequest from localhost:5555 with offerId b7f55bca-f193-4c4a-a644-8c5444432253 and uid 15da3511-afb0-455a-b825-0398c51e141b
INFO  [2019-01-20 19:12:55,831] bisq.core.offer.OpenOfferManager: Send OfferAvailabilityResponse with offerId b7f55bca-f193-4c4a-a644-8c5444432253 and uid 519d7461-f07e-464c-aa6d-84782e380df6 to peer localhost:5555
INFO  [2019-01-20 19:12:55,834] bisq.core.offer.OpenOfferManager: Send AckMessage for OfferAvailabilityRequest to peer localhost:5555 with offerId b7f55bca-f193-4c4a-a644-8c5444432253 and sourceUid 15da3511-afb0-455a-b825-0398c51e141b
INFO  [2019-01-20 19:12:55,837] bisq.core.offer.OpenOfferManager: OfferAvailabilityResponse arrived at peer: offerId=b7f55bca-f193-4c4a-a644-8c5444432253; uid=519d7461-f07e-464c-aa6d-84782e380df6
INFO  [2019-01-20 19:12:55,861] bisq.core.offer.OpenOfferManager: Received AckMessage for OfferAvailabilityResponse with offerId b7f55bca-f193-4c4a-a644-8c5444432253 and uid 519d7461-f07e-464c-aa6d-84782e380df6
INFO  [2019-01-20 19:12:55,889] bisq.core.offer.OpenOfferManager: AckMessage for OfferAvailabilityRequest arrived at takersNodeAddress localhost:5555. offerId=b7f55bca-f193-4c4a-a644-8c5444432253, sourceUid=15da3511-afb0-455a-b825-0398c51e141b
INFO  [2019-01-20 19:12:55,944] bisq.core.trade.TradeManager: Received PayDepositRequest from localhost:5555 with tradeId b7f55bca-f193-4c4a-a644-8c5444432253 and uid d1a20b7d-56ca-4a58-b4d3-ce7da7394d75
INFO  [2019-01-20 19:12:55,944] bisq.common.taskrunner.TaskRunner: Run task: MakerProcessPayDepositRequest
INFO  [2019-01-20 19:12:55,946] bisq.common.taskrunner.TaskRunner: Run task: CheckIfPeerIsBanned
INFO  [2019-01-20 19:12:55,946] bisq.common.taskrunner.TaskRunner: Run task: MakerVerifyArbitratorSelection
INFO  [2019-01-20 19:12:55,946] bisq.common.taskrunner.TaskRunner: Run task: MakerVerifyMediatorSelection
INFO  [2019-01-20 19:12:55,946] bisq.common.taskrunner.TaskRunner: Run task: MakerVerifyTakerAccount
INFO  [2019-01-20 19:12:55,946] bisq.common.taskrunner.TaskRunner: Run task: VerifyPeersAccountAgeWitness
INFO  [2019-01-20 19:12:55,947] bisq.common.taskrunner.TaskRunner: Run task: MakerVerifyTakerFeePayment
INFO  [2019-01-20 19:12:55,947] bisq.common.taskrunner.TaskRunner: Run task: MakerCreateAndSignContract
INFO  [2019-01-20 19:12:55,958] org.bitcoinj.wallet.WalletFiles: Saving wallet; last seen block is height 632, date 2019-01-20T19:00:57Z, hash 270fb0fb570f8c28eb7af36d73fdcc603ea31ca756ae99e1372751e7bf345686
INFO  [2019-01-20 19:12:55,966] org.bitcoinj.wallet.WalletFiles: Save completed in 8.137 ms
INFO  [2019-01-20 19:12:55,976] bisq.common.taskrunner.TaskRunner: Run task: BuyerAsMakerCreatesAndSignsDepositTx
INFO  [2019-01-20 19:12:55,979] org.bitcoinj.wallet.WalletFiles: Saving wallet; last seen block is height 632, date 2019-01-20T19:00:57Z, hash 270fb0fb570f8c28eb7af36d73fdcc603ea31ca756ae99e1372751e7bf345686
INFO  [2019-01-20 19:12:55,991] org.bitcoinj.wallet.WalletFiles: Save completed in 11.08 ms
INFO  [2019-01-20 19:12:55,992] org.bitcoinj.wallet.Wallet: Completing send tx with 1 outputs totalling 0.03 BTC and a fee of 0.00 BTC/kB
WARN  [2019-01-20 19:12:55,992] org.bitcoinj.wallet.Wallet: Insufficient value in wallet for send: needed 0.02 BTC more
WARN  [2019-01-20 19:12:55,992] bisq.core.btc.wallet.TradeWalletService: addAvailableInputsAndChangeOutputs: sendRequest.tx=  15123cb87c2738cf6327311d39a825fec8d7d04a2df801b1808a75e61c0701e9
  INCOMPLETE: No inputs!
, sendRequest.tx.getOutputs()=[TxOut of 0.03 BTC to mzYXiuizL2j8Es2dWBVnTaDM8YQt7v74VH script:DUP HASH160 PUSHDATA(20)[d0b6b5e9ef45c41bed4ef41f0b755e49c3073601] EQUALVERIFY CHECKSIG]
bisq.core.btc.exceptions.WalletException: org.bitcoinj.core.InsufficientMoneyException: Insufficient money,  missing 0.02 BTC
        at bisq.core.btc.wallet.TradeWalletService.addAvailableInputsAndChangeOutputs(TradeWalletService.java:1254)
        at bisq.core.btc.wallet.TradeWalletService.makerCreatesAndSignsDepositTx(TradeWalletService.java:490)
        at bisq.core.trade.protocol.tasks.buyer_as_maker.BuyerAsMakerCreatesAndSignsDepositTx.run(BuyerAsMakerCreatesAndSignsDepositTx.java:104)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.handleComplete(TaskRunner.java:87)
        at bisq.common.taskrunner.Task.complete(Task.java:58)
        at bisq.core.trade.protocol.tasks.maker.MakerCreateAndSignContract.run(MakerCreateAndSignContract.java:105)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.handleComplete(TaskRunner.java:87)
        at bisq.common.taskrunner.Task.complete(Task.java:58)
        at bisq.core.trade.protocol.tasks.maker.MakerVerifyTakerFeePayment.run(MakerVerifyTakerFeePayment.java:45)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.handleComplete(TaskRunner.java:87)
        at bisq.common.taskrunner.Task.complete(Task.java:58)
        at bisq.core.trade.protocol.tasks.VerifyPeersAccountAgeWitness.run(VerifyPeersAccountAgeWitness.java:85)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.handleComplete(TaskRunner.java:87)
        at bisq.common.taskrunner.Task.complete(Task.java:58)
        at bisq.core.trade.protocol.tasks.maker.MakerVerifyTakerAccount.run(MakerVerifyTakerAccount.java:45)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.handleComplete(TaskRunner.java:87)
        at bisq.common.taskrunner.Task.complete(Task.java:58)
        at bisq.core.trade.protocol.tasks.maker.MakerVerifyMediatorSelection.run(MakerVerifyMediatorSelection.java:48)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.handleComplete(TaskRunner.java:87)
        at bisq.common.taskrunner.Task.complete(Task.java:58)
        at bisq.core.trade.protocol.tasks.maker.MakerVerifyArbitratorSelection.run(MakerVerifyArbitratorSelection.java:48)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.handleComplete(TaskRunner.java:87)
        at bisq.common.taskrunner.Task.complete(Task.java:58)
        at bisq.core.trade.protocol.tasks.CheckIfPeerIsBanned.run(CheckIfPeerIsBanned.java:65)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.handleComplete(TaskRunner.java:87)
        at bisq.common.taskrunner.Task.complete(Task.java:58)
        at bisq.core.trade.protocol.tasks.maker.MakerProcessPayDepositRequest.run(MakerProcessPayDepositRequest.java:97)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.run(TaskRunner.java:60)
        at bisq.core.trade.protocol.BuyerAsMakerProtocol.handleTakeOfferRequest(BuyerAsMakerProtocol.java:147)
        at bisq.core.trade.BuyerAsMakerTrade.handleTakeOfferRequest(BuyerAsMakerTrade.java:101)
        at bisq.core.trade.TradeManager.handlePayDepositRequest(TradeManager.java:336)
        at bisq.core.trade.TradeManager.lambda$new$0(TradeManager.java:177)
        at bisq.network.p2p.P2PService.lambda$onMessage$10(P2PService.java:427)
        at java.util.concurrent.CopyOnWriteArrayList.forEach(CopyOnWriteArrayList.java:891)
        at java.util.concurrent.CopyOnWriteArraySet.forEach(CopyOnWriteArraySet.java:404)
        at bisq.network.p2p.P2PService.onMessage(P2PService.java:426)
        at bisq.network.p2p.network.NetworkNode.lambda$onMessage$4(NetworkNode.java:342)
        at java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
        at java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:580)
        at bisq.network.p2p.network.NetworkNode.onMessage(NetworkNode.java:342)
        at bisq.network.p2p.network.Connection.lambda$null$3(Connection.java:397)
        at java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
        at java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:580)
        at bisq.network.p2p.network.Connection.lambda$onMessage$4(Connection.java:397)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:748)
Caused by: org.bitcoinj.core.InsufficientMoneyException: Insufficient money,  missing 0.02 BTC
        at org.bitcoinj.wallet.Wallet.calculateFee(Wallet.java:4987)
        at org.bitcoinj.wallet.Wallet.completeTx(Wallet.java:3980)
        at bisq.core.btc.wallet.TradeWalletService.addAvailableInputsAndChangeOutputs(TradeWalletService.java:1249)
        ... 55 more
ERROR [2019-01-20 19:12:56,002] bisq.common.taskrunner.Task: An error occurred at task: BuyerAsMakerCreatesAndSignsDepositTx
Exception message: org.bitcoinj.core.InsufficientMoneyException: Insufficient money,  missing 0.02 BTC
ERROR [2019-01-20 19:12:56,002] bisq.common.taskrunner.TaskRunner: Task failed: BuyerAsMakerCreatesAndSignsDepositTx / errorMessage: An error occurred at task: BuyerAsMakerCreatesAndSignsDepositTx
Exception message: org.bitcoinj.core.InsufficientMoneyException: Insufficient money,  missing 0.02 BTC
INFO  [2019-01-20 19:12:56,002] network.bisq.api.app.Api: onTakeOfferRequestErrorMessageHandler
ERROR [2019-01-20 19:12:56,002] bisq.core.trade.protocol.TradeProtocol: An error occurred at task: BuyerAsMakerCreatesAndSignsDepositTx
Exception message: org.bitcoinj.core.InsufficientMoneyException: Insufficient money,  missing 0.02 BTC
WARN  [2019-01-20 19:12:56,003] bisq.core.trade.protocol.TradeProtocol: cleanupTradableOnFault tradeState=PREPARATION
WARN  [2019-01-20 19:12:56,003] bisq.core.trade.TradeManager: We found an outdated addressEntry for trade 7f69fefa-adce-481a-9d13-312a9cdc20a2
WARN  [2019-01-20 19:12:56,003] bisq.core.trade.TradeManager: We found an outdated addressEntry for trade 3ae4dc68-1954-411d-a803-4c6e52f297c1
WARN  [2019-01-20 19:12:56,003] bisq.core.trade.TradeManager: We found an outdated addressEntry for trade 341fbbe4-5dff-4765-87ae-f8d6cffd38b6
WARN  [2019-01-20 19:12:56,003] bisq.core.trade.TradeManager: We found an outdated addressEntry for trade 63dc3663-792e-4a14-ae7d-fb27559cd875
WARN  [2019-01-20 19:12:56,003] bisq.core.trade.TradeManager: We found an outdated addressEntry for trade cdd3532b-46fa-474c-8dc0-439b050d7ca5
WARN  [2019-01-20 19:12:56,003] bisq.core.trade.TradeManager: We found an outdated addressEntry for trade b7f55bca-f193-4c4a-a644-8c5444432253
INFO  [2019-01-20 19:12:56,003] bisq.core.btc.wallet.BtcWalletService: swap addressEntry with address mmz3jCcjdEXPQSneT8yhmn6DW17e5HRrEM and offerId b7f55bca-f193-4c4a-a644-8c5444432253 from context MULTI_SIG to available
WARN  [2019-01-20 19:12:56,004] bisq.core.trade.TradeManager: We found an outdated addressEntry for trade b7f55bca-f193-4c4a-a644-8c5444432253
...

Taker times out and errors with depositTx is null. Can provide more logs if needed :)
@ManfredKarrer
Copy link
Member

Do you remember how you could get into that issue? Have you done anything special, like taking an offer but then canceling it and taking it again.... We see those issues from time to time but we don't know yet how that happens. Seems it happens in some non typical use cases or as a result of a previous bug.

@lacksfish
Copy link
Author

lacksfish commented Jan 21, 2019 •
edited
Loading

The balance of the maker is sufficient. I've just re-ran the process of buying BTC as a maker and have again yielded the following error.

I'm wondering if it has to do with the security deposit exceeding the wallet balance... To be fair it does not fail every time, which is additionally confusing.

INFO  [2019-01-21 13:36:07,468] bisq.core.offer.OpenOfferManager: Received OfferAvailabilityRequest from localhost:5555 with offerId f8ca4bfe-4e54-4f97-b359-534b42d25f17 and uid 042ca1b4-1edf-4a0e-8668-3cfabcff6f84
INFO  [2019-01-21 13:36:07,469] bisq.core.offer.OpenOfferManager: Send OfferAvailabilityResponse with offerId f8ca4bfe-4e54-4f97-b359-534b42d25f17 and uid befd5ae8-c32d-49cd-8422-aff58da9e6f2 to peer localhost:5555
INFO  [2019-01-21 13:36:07,471] bisq.core.offer.OpenOfferManager: Send AckMessage for OfferAvailabilityRequest to peer localhost:5555 with offerId f8ca4bfe-4e54-4f97-b359-534b42d25f17 and sourceUid 042ca1b4-1edf-4a0e-8668-3cfabcff6f84
INFO  [2019-01-21 13:36:07,474] bisq.core.offer.OpenOfferManager: OfferAvailabilityResponse arrived at peer: offerId=f8ca4bfe-4e54-4f97-b359-534b42d25f17; uid=befd5ae8-c32d-49cd-8422-aff58da9e6f2
INFO  [2019-01-21 13:36:07,525] bisq.core.offer.OpenOfferManager: AckMessage for OfferAvailabilityRequest arrived at takersNodeAddress localhost:5555. offerId=f8ca4bfe-4e54-4f97-b359-534b42d25f17, sourceUid=042ca1b4-1edf-4a0e-8668-3cfabcff6f84
INFO  [2019-01-21 13:36:07,659] bisq.core.offer.OpenOfferManager: Received AckMessage for OfferAvailabilityResponse with offerId f8ca4bfe-4e54-4f97-b359-534b42d25f17 and uid befd5ae8-c32d-49cd-8422-aff58da9e6f2
INFO  [2019-01-21 13:36:29,878] bisq.core.offer.OpenOfferManager: Received OfferAvailabilityRequest from localhost:5555 with offerId f8ca4bfe-4e54-4f97-b359-534b42d25f17 and uid ac6610e1-7829-4293-96cf-9546a2a8193e
INFO  [2019-01-21 13:36:29,878] bisq.core.offer.OpenOfferManager: Send OfferAvailabilityResponse with offerId f8ca4bfe-4e54-4f97-b359-534b42d25f17 and uid 93b93120-93e5-4010-9a94-cc071635f8e7 to peer localhost:5555
INFO  [2019-01-21 13:36:29,882] bisq.core.offer.OpenOfferManager: Send AckMessage for OfferAvailabilityRequest to peer localhost:5555 with offerId f8ca4bfe-4e54-4f97-b359-534b42d25f17 and sourceUid ac6610e1-7829-4293-96cf-9546a2a8193e
INFO  [2019-01-21 13:36:29,886] bisq.core.offer.OpenOfferManager: OfferAvailabilityResponse arrived at peer: offerId=f8ca4bfe-4e54-4f97-b359-534b42d25f17; uid=93b93120-93e5-4010-9a94-cc071635f8e7
INFO  [2019-01-21 13:36:29,937] bisq.core.offer.OpenOfferManager: Received AckMessage for OfferAvailabilityResponse with offerId f8ca4bfe-4e54-4f97-b359-534b42d25f17 and uid 93b93120-93e5-4010-9a94-cc071635f8e7
INFO  [2019-01-21 13:36:29,937] bisq.core.offer.OpenOfferManager: AckMessage for OfferAvailabilityRequest arrived at takersNodeAddress localhost:5555. offerId=f8ca4bfe-4e54-4f97-b359-534b42d25f17, sourceUid=ac6610e1-7829-4293-96cf-9546a2a8193e
INFO  [2019-01-21 13:36:30,048] bisq.core.trade.TradeManager: Received PayDepositRequest from localhost:5555 with tradeId f8ca4bfe-4e54-4f97-b359-534b42d25f17 and uid ba19ce3c-f60b-48a6-800d-a8219c478ef6
INFO  [2019-01-21 13:36:30,056] bisq.common.taskrunner.TaskRunner: Run task: MakerProcessPayDepositRequest
INFO  [2019-01-21 13:36:30,057] bisq.common.taskrunner.TaskRunner: Run task: CheckIfPeerIsBanned
INFO  [2019-01-21 13:36:30,057] bisq.common.taskrunner.TaskRunner: Run task: MakerVerifyArbitratorSelection
INFO  [2019-01-21 13:36:30,057] bisq.common.taskrunner.TaskRunner: Run task: MakerVerifyMediatorSelection
INFO  [2019-01-21 13:36:30,057] bisq.common.taskrunner.TaskRunner: Run task: MakerVerifyTakerAccount
INFO  [2019-01-21 13:36:30,057] bisq.common.taskrunner.TaskRunner: Run task: VerifyPeersAccountAgeWitness
INFO  [2019-01-21 13:36:30,057] bisq.common.taskrunner.TaskRunner: Run task: MakerVerifyTakerFeePayment
INFO  [2019-01-21 13:36:30,057] bisq.common.taskrunner.TaskRunner: Run task: MakerCreateAndSignContract
INFO  [2019-01-21 13:36:30,067] bisq.common.taskrunner.TaskRunner: Run task: BuyerAsMakerCreatesAndSignsDepositTx
INFO  [2019-01-21 13:36:30,084] org.bitcoinj.wallet.Wallet: Completing send tx with 1 outputs totalling 0.03 BTC and a fee of 0.00 BTC/kB
WARN  [2019-01-21 13:36:30,089] org.bitcoinj.wallet.Wallet: Insufficient value in wallet for send: needed 0.02 BTC more
WARN  [2019-01-21 13:36:30,090] bisq.core.btc.wallet.TradeWalletService: addAvailableInputsAndChangeOutputs: sendRequest.tx=  a7d8d15b0bc79a52929f7c6330f9b18b02ff7a388257e680737c478f3efc71ee
  INCOMPLETE: No inputs!
, sendRequest.tx.getOutputs()=[TxOut of 0.03 BTC to mx3DgaQtCAhceDYLpv2c3KCUemXkYUjLR4 script:DUP HASH160 PUSHDATA(20)[b53b564075d896beea1775179d845363dd4620bf] EQUALVERIFY CHECKSIG]
bisq.core.btc.exceptions.WalletException: org.bitcoinj.core.InsufficientMoneyException: Insufficient money,  missing 0.02 BTC
        at bisq.core.btc.wallet.TradeWalletService.addAvailableInputsAndChangeOutputs(TradeWalletService.java:1254)
        at bisq.core.btc.wallet.TradeWalletService.makerCreatesAndSignsDepositTx(TradeWalletService.java:490)
        at bisq.core.trade.protocol.tasks.buyer_as_maker.BuyerAsMakerCreatesAndSignsDepositTx.run(BuyerAsMakerCreatesAndSignsDepositTx.java:104)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.handleComplete(TaskRunner.java:87)
        at bisq.common.taskrunner.Task.complete(Task.java:58)
        at bisq.core.trade.protocol.tasks.maker.MakerCreateAndSignContract.run(MakerCreateAndSignContract.java:105)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.handleComplete(TaskRunner.java:87)
        at bisq.common.taskrunner.Task.complete(Task.java:58)
        at bisq.core.trade.protocol.tasks.maker.MakerVerifyTakerFeePayment.run(MakerVerifyTakerFeePayment.java:45)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.handleComplete(TaskRunner.java:87)
        at bisq.common.taskrunner.Task.complete(Task.java:58)
        at bisq.core.trade.protocol.tasks.VerifyPeersAccountAgeWitness.run(VerifyPeersAccountAgeWitness.java:85)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.handleComplete(TaskRunner.java:87)
        at bisq.common.taskrunner.Task.complete(Task.java:58)
        at bisq.core.trade.protocol.tasks.maker.MakerVerifyTakerAccount.run(MakerVerifyTakerAccount.java:45)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.handleComplete(TaskRunner.java:87)
        at bisq.common.taskrunner.Task.complete(Task.java:58)
        at bisq.core.trade.protocol.tasks.maker.MakerVerifyMediatorSelection.run(MakerVerifyMediatorSelection.java:48)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.handleComplete(TaskRunner.java:87)
        at bisq.common.taskrunner.Task.complete(Task.java:58)
        at bisq.core.trade.protocol.tasks.maker.MakerVerifyArbitratorSelection.run(MakerVerifyArbitratorSelection.java:48)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.handleComplete(TaskRunner.java:87)
        at bisq.common.taskrunner.Task.complete(Task.java:58)
        at bisq.core.trade.protocol.tasks.CheckIfPeerIsBanned.run(CheckIfPeerIsBanned.java:65)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.handleComplete(TaskRunner.java:87)
        at bisq.common.taskrunner.Task.complete(Task.java:58)
        at bisq.core.trade.protocol.tasks.maker.MakerProcessPayDepositRequest.run(MakerProcessPayDepositRequest.java:97)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.run(TaskRunner.java:60)
        at bisq.core.trade.protocol.BuyerAsMakerProtocol.handleTakeOfferRequest(BuyerAsMakerProtocol.java:147)
        at bisq.core.trade.BuyerAsMakerTrade.handleTakeOfferRequest(BuyerAsMakerTrade.java:101)
        at bisq.core.trade.TradeManager.handlePayDepositRequest(TradeManager.java:336)
        at bisq.core.trade.TradeManager.lambda$new$0(TradeManager.java:177)
        at bisq.network.p2p.P2PService.lambda$onMessage$10(P2PService.java:427)
        at java.util.concurrent.CopyOnWriteArrayList.forEach(CopyOnWriteArrayList.java:891)
        at java.util.concurrent.CopyOnWriteArraySet.forEach(CopyOnWriteArraySet.java:404)
        at bisq.network.p2p.P2PService.onMessage(P2PService.java:426)
        at bisq.network.p2p.network.NetworkNode.lambda$onMessage$4(NetworkNode.java:342)
        at java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
        at java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:580)
        at bisq.network.p2p.network.NetworkNode.onMessage(NetworkNode.java:342)
        at bisq.network.p2p.network.Connection.lambda$null$3(Connection.java:397)
        at java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
        at java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:580)
        at bisq.network.p2p.network.Connection.lambda$onMessage$4(Connection.java:397)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
        at java.lang.Thread.run(Thread.java:748)
Caused by: org.bitcoinj.core.InsufficientMoneyException: Insufficient money,  missing 0.02 BTC
        at org.bitcoinj.wallet.Wallet.calculateFee(Wallet.java:4987)
        at org.bitcoinj.wallet.Wallet.completeTx(Wallet.java:3980)
        at bisq.core.btc.wallet.TradeWalletService.addAvailableInputsAndChangeOutputs(TradeWalletService.java:1249)
        ... 55 more
ERROR [2019-01-21 13:36:30,100] bisq.common.taskrunner.Task: An error occurred at task: BuyerAsMakerCreatesAndSignsDepositTx
Exception message: org.bitcoinj.core.InsufficientMoneyException: Insufficient money,  missing 0.02 BTC
ERROR [2019-01-21 13:36:30,100] bisq.common.taskrunner.TaskRunner: Task failed: BuyerAsMakerCreatesAndSignsDepositTx / errorMessage: An error occurred at task: BuyerAsMakerCreatesAndSignsDepositTx
Exception message: org.bitcoinj.core.InsufficientMoneyException: Insufficient money,  missing 0.02 BTC
INFO  [2019-01-21 13:36:30,101] network.bisq.api.app.Api: onTakeOfferRequestErrorMessageHandler
ERROR [2019-01-21 13:36:30,101] bisq.core.trade.protocol.TradeProtocol: An error occurred at task: BuyerAsMakerCreatesAndSignsDepositTx
Exception message: org.bitcoinj.core.InsufficientMoneyException: Insufficient money,  missing 0.02 BTC
WARN  [2019-01-21 13:36:30,101] bisq.core.trade.protocol.TradeProtocol: cleanupTradableOnFault tradeState=PREPARATION
WARN  [2019-01-21 13:36:30,101] bisq.core.trade.TradeManager: We found an outdated addressEntry for trade 7f69fefa-adce-481a-9d13-312a9cdc20a2
WARN  [2019-01-21 13:36:30,101] bisq.core.trade.TradeManager: We found an outdated addressEntry for trade 3ae4dc68-1954-411d-a803-4c6e52f297c1
WARN  [2019-01-21 13:36:30,102] bisq.core.trade.TradeManager: We found an outdated addressEntry for trade 341fbbe4-5dff-4765-87ae-f8d6cffd38b6
WARN  [2019-01-21 13:36:30,102] bisq.core.trade.TradeManager: We found an outdated addressEntry for trade 63dc3663-792e-4a14-ae7d-fb27559cd875
WARN  [2019-01-21 13:36:30,102] bisq.core.trade.TradeManager: We found an outdated addressEntry for trade cdd3532b-46fa-474c-8dc0-439b050d7ca5
WARN  [2019-01-21 13:36:30,102] bisq.core.trade.TradeManager: We found an outdated addressEntry for trade b7f55bca-f193-4c4a-a644-8c5444432253
WARN  [2019-01-21 13:36:30,102] bisq.core.trade.TradeManager: We found an outdated addressEntry for trade 7a2dfa11-9db3-4bb9-8afa-bf9785aeae03
WARN  [2019-01-21 13:36:30,102] bisq.core.trade.TradeManager: We found an outdated addressEntry for trade f8ca4bfe-4e54-4f97-b359-534b42d25f17
INFO  [2019-01-21 13:36:30,102] bisq.core.btc.wallet.BtcWalletService: swap addressEntry with address myjPwm4FWfwXJaw2oYxUEh96HUGxN6mCu5 and offerId f8ca4bfe-4e54-4f97-b359-534b42d25f17 from context MULTI_SIG to available
WARN  [2019-01-21 13:36:30,102] bisq.core.trade.TradeManager: We found an outdated addressEntry for trade f8ca4bfe-4e54-4f97-b359-534b42d25f17

@ripcurlx ripcurlx mentioned this issue Jan 22, 2019
Closed
@ripcurlx
Copy link
Contributor

ripcurlx commented Jan 22, 2019 •
edited
Loading

In issue #2301 it looks like as it might happen when two trades are done with the same peer. Still I have done this lots of times on Regtest without any problems. I'll try to re-create this problem locally.

@ripcurlx
Copy link
Contributor

@lacksfish Could you please upload your regtest data directory so I can have a more in-depth look on this issue?

@huey735
Copy link
Member

huey735 commented Jul 22, 2019

@sqrrm @ManfredKarrer
This bug is still affecting offer makers - https://bisq.community/search?q=Insufficient%20order%3Alatest_topic

@lacksfish
Copy link
Author

lacksfish commented Aug 17, 2019 •
edited
Loading

Am still getting Insufficient money, missing 0.010484 BTC, but the balance is definitely sufficient.

@lacksfish
Copy link
Author

lacksfish commented Aug 17, 2019 •
edited
Loading

This is the most recent error log with the DEBUG loglevel. This happens when creating the offer:

org.bitcoinj.core.InsufficientMoneyException: Insufficient money,  missing 0.01046 BTC
        at org.bitcoinj.wallet.Wallet.calculateFee(Wallet.java:4987)
        at org.bitcoinj.wallet.Wallet.completeTx(Wallet.java:3980)
        at bisq.core.btc.wallet.TradeWalletService.createBtcTradingFeeTx(TradeWalletService.java:215)
        at bisq.core.offer.placeoffer.tasks.CreateMakerFeeTx.run(CreateMakerFeeTx.java:82)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.handleComplete(TaskRunner.java:87)
        at bisq.common.taskrunner.Task.complete(Task.java:58)
        at bisq.core.offer.placeoffer.tasks.ValidateOffer.run(ValidateOffer.java:102)
        at bisq.common.taskrunner.TaskRunner.next(TaskRunner.java:69)
        at bisq.common.taskrunner.TaskRunner.run(TaskRunner.java:60)
        at bisq.core.offer.placeoffer.PlaceOfferProtocol.placeOffer(PlaceOfferProtocol.java:83)
        at bisq.core.offer.OpenOfferManager.placeOffer(OpenOfferManager.java:344)
        at network.bisq.api.BisqProxy.offerMake(BisqProxy.java:336)
        at network.bisq.api.service.v1.OfferResource.createOffer(OfferResource.java:87)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.glassfish.jersey.server.model.internal.ResourceMethodInvocationHandlerFactory$1.invoke(ResourceMethodInvocationHandlerFactory.java:81)
        at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher$1.run(AbstractJavaResourceMethodDispatcher.java:144)
        at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.invoke(AbstractJavaResourceMethodDispatcher.java:161)
        at org.glassfish.jersey.server.model.internal.JavaResourceMethodDispatcherProvider$VoidOutInvoker.doDispatch(JavaResourceMethodDispatcherProvider.java:143)
        at org.glassfish.jersey.server.model.internal.AbstractJavaResourceMethodDispatcher.dispatch(AbstractJavaResourceMethodDispatcher.java:99)
        at org.glassfish.jersey.server.model.ResourceMethodInvoker.invoke(ResourceMethodInvoker.java:389)
        at org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:347)
        at org.glassfish.jersey.server.model.ResourceMethodInvoker.apply(ResourceMethodInvoker.java:102)
        at org.glassfish.jersey.server.ServerRuntime$2.run(ServerRuntime.java:326)
        at org.glassfish.jersey.internal.Errors$1.call(Errors.java:271)
        at org.glassfish.jersey.internal.Errors$1.call(Errors.java:267)
        at org.glassfish.jersey.internal.Errors.process(Errors.java:315)
        at org.glassfish.jersey.internal.Errors.process(Errors.java:297)
        at org.glassfish.jersey.internal.Errors.process(Errors.java:267)
        at org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:317)
        at org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:305)
        at org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:1154)
        at org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:473)
        at org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:427)
        at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:388)
        at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:341)
        at org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:228)
        at io.dropwizard.jetty.NonblockingServletHolder.handle(NonblockingServletHolder.java:49)
        at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1650)
        at io.dropwizard.servlets.ThreadNameFilter.doFilter(ThreadNameFilter.java:34)
        at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637)
        at io.dropwizard.jersey.filter.AllowedMethodsFilter.handle(AllowedMethodsFilter.java:45)
        at io.dropwizard.jersey.filter.AllowedMethodsFilter.doFilter(AllowedMethodsFilter.java:39)
        at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637)
        at network.bisq.api.service.AuthFilter.doFilter(AuthFilter.java:40)
        at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637)
        at org.eclipse.jetty.servlets.CrossOriginFilter.handle(CrossOriginFilter.java:308)
        at org.eclipse.jetty.servlets.CrossOriginFilter.doFilter(CrossOriginFilter.java:262)
        at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637)
        at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:533)
        at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:188)
        at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1253)
        at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:168)
        at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:473)
        at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:166)
        at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1155)
        at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
        at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132)
        at com.codahale.metrics.jetty9.InstrumentedHandler.handle(InstrumentedHandler.java:241)
        at io.dropwizard.jetty.ContextRoutingHandler.handle(ContextRoutingHandler.java:38)
        at org.eclipse.jetty.server.handler.gzip.GzipHandler.handle(GzipHandler.java:455)
        at io.dropwizard.jetty.BiDiGzipHandler.handle(BiDiGzipHandler.java:68)
        at org.eclipse.jetty.server.handler.RequestLogHandler.handle(RequestLogHandler.java:56)
        at org.eclipse.jetty.server.handler.StatisticsHandler.handle(StatisticsHandler.java:169)
        at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132)
        at org.eclipse.jetty.server.Server.handle(Server.java:561)
        at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:334)
        at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251)
        at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:279)
        at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:104)
        at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:124)
        at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:247)
        at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.produce(EatWhatYouKill.java:140)
        at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:131)
        at org.eclipse.jetty.util.thread.ReservedThreadExecutor$ReservedThread.run(ReservedThreadExecutor.java:243)
        at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:679)
        at org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:597)
        at java.lang.Thread.run(Thread.java:748)
INFO  [2019-08-17 19:56:02,133] bisq.core.btc.wallet.TradeWalletService: reservedFundsForOffer 0.01
INFO  [2019-08-17 19:56:02,134] bisq.core.btc.wallet.TradeWalletService: tradingFee 0.0004
INFO  [2019-08-17 19:56:02,134] bisq.core.btc.wallet.TradeWalletService: txFee 0.00006
INFO  [2019-08-17 19:56:02,134] org.bitcoinj.wallet.Wallet: Completing send tx with 2 outputs totalling 0.0104 BTC and a fee of 0.00 BTC/kB
WARN  [2019-08-17 19:56:02,134] org.bitcoinj.wallet.Wallet: Insufficient value in wallet for send: needed 0.01046 BTC more
WARN  [2019-08-17 19:56:02,134] bisq.core.btc.wallet.TradeWalletService: Balance = 0; CoinSelector = bisq.core.btc.wallet.BtcCoinSelector@64c3c9bd
WARN  [2019-08-17 19:56:02,134] bisq.core.btc.wallet.TradeWalletService: createBtcTradingFeeTx failed: tradingFeeTx=  20dece605e46cfbcfbf5b20d1d44a7cedcb196610a751737d7284f4d0b619121
  INCOMPLETE: No inputs!
, txOutputs=[TxOut of 0.0004 BTC to n42LBMEptU3Lfsc5Bo9UfyKR7bQfrvSfDr script:DUP HASH160 PUSHDATA(20)[f6e1192b7cb0bb3d662ba3d6d616ec4f28577985] EQUALVERIFY CHECKSIG, TxOut of 0.01 BTC to n27cxdXo6vfZm2ikURiRHpVSn5NFMkc6K3 script:DUP HASH160 PUSHDATA(20)[e1f0ef34166736040841f44ef8a6093d1236a182] EQUALVERIFY CHECKSIG]
ERROR [2019-08-17 19:56:02,136] bisq.common.taskrunner.Task: An error occurred at task: CreateMakerFeeTx
Exception message: Insufficient money,  missing 0.01046 BTC
ERROR [2019-08-17 19:56:02,136] bisq.common.taskrunner.TaskRunner: Task failed: CreateMakerFeeTx / errorMessage: An error occurred at task: CreateMakerFeeTx
Exception message: Insufficient money,  missing 0.01046 BTC
ERROR [2019-08-17 19:56:02,136] bisq.core.offer.placeoffer.PlaceOfferProtocol: An error occurred at task: CreateMakerFeeTx
Exception message: Insufficient money,  missing 0.01046 BTC

I want to emphasize this especially:

WARN  [2019-08-17 19:56:02,134] bisq.core.btc.wallet.TradeWalletService: Balance = 0; CoinSelector = bisq.core.btc.wallet.BtcCoinSelector@64c3c9bd
WARN  [2019-08-17 19:56:02,134] bisq.core.btc.wallet.TradeWalletService: createBtcTradingFeeTx failed: tradingFeeTx=  20dece605e46cfbcfbf5b20d1d44a7cedcb196610a751737d7284f4d0b619121
  INCOMPLETE: No inputs!

@ripcurlx ripcurlx added the is:priority PR or issue marked with this label is up for compensation label Feb 18, 2020
@ripcurlx
Copy link
Contributor

Related to: #2301

@ripcurlx ripcurlx added the is:critical https://bisq.wiki/Critical_bug label Feb 18, 2020
@ghost
Copy link

ghost commented Apr 21, 2020

A reproducible way to encounter this problem is as follows (from #3871):

  • Create and save an offer to sell 0.05 BTC for a price of 6400
  • Go to Open Offers and click on the edit icon
  • Change the price to 6452.3042 and press tab. The amount of BTC changes to 0.0501
  • Save the offer.

When the offer is taken, the maker gets "Insufficient money, missing 0.0001 BTC". The missing amount corresponds to the amount that BTC got adjusted by when editing the offer.
PR #4182 fixes this particular example by preventing the BTC amount of the offer from being adjusted.

Whether there is another scenario for encountering this "Insufficient money" error remains to be seen. I suspect there still might be, since in the OP's second example the missing amount is 0.01046 which is 5 decimals whereas offers always limit BTC amounts to 4 decimals. Perhaps another way to encounter this would be if the offer's reserved funds were spent before the offer is taken.

@ghost ghost mentioned this issue May 10, 2020
Closed
@ghost ghost mentioned this issue May 28, 2020
Closed
@dmos62
Copy link
Contributor

dmos62 commented Jul 9, 2020

@jmacxx hypothetized that his bugfix might not address all instances of this bug, but there doesn't seem to be any activity here since the fix was released. @sqrrm should we close the issue?

@sqrrm
Copy link
Member

sqrrm commented Jul 9, 2020

Let's close it and open a new one if there is something more specific that wasn't covered by the fix.

@sqrrm sqrrm closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:bug in:trade-process is:critical https://bisq.wiki/Critical_bug is:priority PR or issue marked with this label is up for compensation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ripcurlx @ManfredKarrer @dmos62 @lacksfish @sqrrm @huey735