Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show current tx fee rate on main screen #4412

Closed
jmacxx opened this issue Aug 15, 2020 · 7 comments · Fixed by #4676
Closed

Show current tx fee rate on main screen #4412

jmacxx opened this issue Aug 15, 2020 · 7 comments · Fixed by #4676
Labels
good first issue in:gui

Comments

@jmacxx
Copy link
Contributor

jmacxx commented Aug 15, 2020

Description

It would be very useful for the current fee estimation to be shown on the main screen - at the moment the only way to see it is to watch the Bisq log file for a message like this:

INFO  b.c.p.f.FeeService: BTC tx fee: txFeePerByte=11

If txFeePerByte=11 was shown in the main screen it would be much easier to determine if it is a good time to make a transaction.
It is more useful than the 0.00 BTC Reserved and 0.00 BTC Locked currently shown because they can also be found on the Funds screen.

Version

all Bisq, up to currently 1.3.7

Expected behaviour

Show the tx fee on the main screen, to the right of Available balance, replacing Reserved/Locked balances.
@chimp1984
Copy link
Contributor

The fee is shown in the settings if one has selected to use the fee estimation. but I agree its hard to find and it would be nice to see it more promonent. Maybe @pedromvpg could make a suggestion how we can add it to the UI? We should avoid overloading the UI with information as well, so its a hard balance we the UI is already very information heavy.

@jmacxx
Copy link
Contributor Author

jmacxx commented Aug 27, 2020

👍
Doesn't necessarily have to be on the main screen it would be great if it was shown anywhere.. even Settings/Network Info screen would be good. But I don't see it anywhere, hence the current need to tail the logs. As a trader looking to make or take an offer, I want to know what Bisq is thinking regards the current mempool state (it can be 5 minutes behind https://mempool.space), and that only seems to be in the logs at the moment.

@chimp1984
Copy link
Contributor

Its here: withdrawal tx fee
Screen Shot 2020-08-27 at 21 32 55

@chimp1984
Copy link
Contributor

But I agree its nto very visible... Feel free to make a UI suggestion where you think it fits in best.

@jmacxx
Copy link
Contributor Author

jmacxx commented Aug 28, 2020

That's the withdrawal fee. I'm referring to the fee used for making or taking an offer, which varies from 10 to whatever mempool.space currently reports.

@jmacxx jmacxx closed this as completed Aug 28, 2020
@chimp1984
Copy link
Contributor

It is the same if user has not set it to custom. E.g. we use the fee from estimation service for recommended withdrawal fee and for trade txs. But as said I agree its hard to see and would prefer to have it explicit displayed.

@cd2357
Copy link
Contributor

cd2357 commented Oct 20, 2020

Good idea, how about in the Bitcoin connection info in the bottom left?

Screenshot 2020-10-20 at 11 27 57

Not sure why it was closed, reopening as it looks like a simple, doable (and very useful) improvement.

@cd2357 cd2357 reopened this Oct 20, 2020
jmacxx added a commit to jmacxx/bisq that referenced this issue Oct 21, 2020
@jmacxx
Show current tx fee rate on main screen
f7dfcd9 
Tx fee rate is shown in the footer alongside "Synchronized with
Bitcoin Mainnet (using Tor) (x sat/vB)".

Fixes bisq-network#4412
@jmacxx jmacxx mentioned this issue Oct 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue in:gui
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show current tx fee rate on main screen jmacxx/bisq
3 participants
@cd2357 @jmacxx @chimp1984