Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deposit tx not broadcasted #4911

Open
oscarguindzberg opened this issue Dec 7, 2020 · 9 comments
Open

Deposit tx not broadcasted #4911

oscarguindzberg opened this issue Dec 7, 2020 · 9 comments
Labels
a:bug in:trade-process in:wallet

Comments

@oscarguindzberg
Copy link
Contributor

Description

Some users are reporting the trade deposit tx is not broadcasted.
We don't have enough data to reproduce the bug yet. I create this issue as a placeholder, so anyone that can provide info on this subject can post it here.

Version

1.5.0

Steps to reproduce

We don't know yet

Expected behaviour

After trade is taken, deposit tx is marked as pending in bisq and block explorers.

Actual behaviour

I got reports of deposit tx not being broadcasted. But I don't know exactly how they verify that.
We have reports of bisq showing no deposit tx when viewing the trade (maybe this is a different issue).

Screenshots

Device or machine

Additional info

We first need to be able to reproduce the bug in order to fix it.

Things that would help us:

  • Define how the user knows the tx is not broadcasted.
  • Concrete examples: trade id, maker and taker fee txids, deposit tx id
  • bisq logs at the time the trade was taken (if you have logs for taker and maker even better)
  • if using a local bitcoin core node, the logs of bitcoin core at the time the trade was taken
  • does the tx gets broadcasted if bisq is restarted? (bitcoinj broadcasts known unconfirmed txs when it starts)
  • is this just a deposit tx problem? have you experienced this with any other type of tx?
  • usernames that experienced this, so we can contact them to ask questions

This is probably not related to #4870 but I post the link just in case.
@oscarguindzberg
Copy link
Contributor Author

oscarguindzberg commented Dec 7, 2020 •
edited

Extracted from support chat on keybase. maybe related

bitcoinlibre
I have a issue with deposit transaction Is in a open trade. Is blank and I do not cant continue with deal
I need support to trade 4523348. thanks

thebae
Hi I need support pls Trade ID677236
@bitcoinlibre I have the same problem :)
Does it say this underneath blank deposit tx ID.....Timeout reached. Protocol did not complete in 30 sec.

@ghost

This comment has been minimized.

Sign in to view
@appideias
Copy link

appideias commented Dec 8, 2020 •
edited

One example:

Maker: 794c4e6b3ff5f81071c5f36000e1228c1677a60b7c85907d116f79a83d7becf4
Taker: abaa0b62ab2ea9e0702c4c000f94023854a9194db4b8c271a2504487d0cd37a2
Deposit: N/A -> That's the problem.

Tried SVP delete/resync from both ends: no luck.

Original thread:

bisq-network/support#591

@oscarguindzberg
Copy link
Contributor Author

Probably related #4905

@oscarguindzberg
Copy link
Contributor Author

@appideias
Do you have bisq taker and maker logs at the time the tx was taken?

@oscarguindzberg
Copy link
Contributor Author

@jmacxx the bug you are reporting seems to be a different one. Could you create a new issue with subject " bisq wallet shows nnn balance for address xxx but the block explorer shows zero" or something like that?

@oscarguindzberg oscarguindzberg mentioned this issue Dec 9, 2020
Closed
@appideias
Copy link

appideias commented Dec 9, 2020 via email

@oscarguindzberg oscarguindzberg mentioned this issue Dec 9, 2020
Closed
@appideias
Copy link

Hi @oscarguindzberg,

What should I do now? Thanks for your help.

@oscarguindzberg
Copy link
Contributor Author

There is a bugfix that may solve this problem. It will be included in 1.5.2 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:bug in:trade-process in:wallet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ripcurlx @oscarguindzberg @appideias