Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSQ Fees equivalent not correctly calulated into BTC in info tooltip #4959

Closed
ghost opened this issue Dec 16, 2020 · 2 comments
Closed

BSQ Fees equivalent not correctly calulated into BTC in info tooltip #4959

ghost opened this issue Dec 16, 2020 · 2 comments

Comments

@ghost
Copy link

ghost commented Dec 16, 2020

Description

When I am about to create trade I see this amount of fees:
image

However on the next screen, I see this:
x

Which is currently:
image

Version

v1.5.1

Steps to reproduce

See description.

Expected behaviour

The numbers will match.

Actual behaviour

See description.

@p2051
Copy link

p2051 commented Jan 22, 2021

It seems that the BSQ trade fee calculation is broken, a more grave example:

When I create a new trade the BSQ trade fee is calculated as 1 BSQ ~= 1.30 EUR
bug01

With BTC/EUR (24230 EUR - calculated based on the price in the screenshot above) and BSQ/BTC (0.00006900 BTC) current price being
bug03

and on the next step the BSQ/BTC calculation is done with 0.000001 BTC
bug04

Based on the current price of BSQ the trade costs 1.67 EUR.

Therefore there are these issues:

  1. The "trade fee" on the initial screen "Create Offer" screen is miscalculated; displayed as ~= 1.30 EUR instead of ~=1.67 EUR
  2. The "trading fee" on the follow-up screen (in alt-text info is misrepresented and miscalculated; displayed as ~= 0.000001 BTC (0.03 EUR) instead of current pricing of ~= 0.000069 BTC (1.68 EUR)
  3. Nomenclature mismatch, in the initial screen it is called "trade fee" on follow-up screen it is called "Trade fee" as label and "trading fee" in the text

@ghost
Copy link

ghost commented Aug 9, 2022

@ripcurlx This issues seems to be outdated and could be closed - described problems was fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants