Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve trade fee display at create and take offer screens and popups #4985

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Improve trade fee display at create and take offer screens and popups #4985

merged 1 commit into from
Dec 21, 2020

Conversation

chimp1984
Copy link
Contributor

@chimp1984 chimp1984 commented Dec 20, 2020 •
edited
Loading

Shows the fiat value and % of trade amount for trade fee and tx fee. If BSQ then we only show fiat value.

Special cases:

  • Price feed not available: No % value shown
  • DAO deactivated: BSQ part hidden

@chimp1984
Copy link
Contributor Author

Fee paid in BTC:
Screen Shot 2020-12-20 at 18 03 10
Screen Shot 2020-12-20 at 18 03 19Screen Shot 2020-12-20 at 18 03 33

Fee paid in BSQ:
Screen Shot 2020-12-20 at 18 03 45
Screen Shot 2020-12-20 at 18 03 54
Screen Shot 2020-12-20 at 18 04 02

ripcurlx
ripcurlx approved these changes Dec 21, 2020
View reviewed changes
Copy link
Contributor

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx added this to the v1.5.3 milestone Dec 21, 2020
@ripcurlx ripcurlx merged commit d805b37 into bisq-network:master Dec 21, 2020
@chimp1984 chimp1984 deleted the improve-trade-fee-display branch December 21, 2020 15:03
@chimp1984 chimp1984 mentioned this pull request Dec 26, 2020
Closed
@chimp1984 chimp1984 mentioned this pull request Jan 27, 2021
Closed
@chimp1984 chimp1984 mentioned this pull request Feb 10, 2021
Closed
@ghost ghost mentioned this pull request Aug 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.5
Development

Successfully merging this pull request may close these issues.
2 participants
@chimp1984 @ripcurlx