Currency filtering is inconsistent

[ghost]

Description

Currency filter (selection drop-down menu) is not working consistently. For instance, there are offers for Zcash and for Doge. I can filter only for Zcash, not for Doge. LBC coin was previously not selectable too, but after an LBC altcoin account was

created. Either I should be able to filter after I have created the specific altcoin account, or I should be able to filter by all altcoins no matter which accounts I have. I assume, the ladder should apply.

Version

1.5.9

Steps to reproduce

Use the drop-down menu to filter for an altcoin. Some you can filter (in my case for instance Zcash), some you cannot (in my case for instance DOGE).

Expected behaviour

Currency filter should be consistent, either with after having created that altcoin account, or filtering through all altcoins no matter which altcoin accounts you have

Actual behaviour

Not possible to filter for certain altcoins.

Screenshots

Device or machine

Windows 64 bit

Additional info

[Conza88]

I think I've see fiat national currencies randomly pop back up into my listing.

[ghost]

Update: screenshots attached

[pazza83]

Default currency selection is missing NGN a currency Bisq is trying to promote.

I am for adding all currencies and not making users have to add them. Not sure if their are any reasons for not doing this?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[ghost]

So we want to remove this whole section from Settings -> Preferences

and show all currencies in filter?

[pazza83]

Hi @xyzmaker123

I think it would be good to make all currencies to be added be default (national currencies and altcoins),

The section can be kept. Users can then use it to remove currencies they do not want to see.

I think removing currencies is better than adding currencies for user experience.

[ghost]

I think set of possible national currencies is really big - I don't think it's good idea to add them all by default. Default national currencies are defined in code

Similar situation with altcoins - list of available by default is also defined in code. We could possibly extend this list about popular altcoins like Dogecoin.

[pazza83]

Hi @xyzmaker123 I have been using Bisq for a while now with all national currencies / altcoins selected and have experienced no decrease in usability.

It just requires one to remember the currency name / ticker when selecting the required market.

My concerns are if currencies are missing users like the one here from Philippines will think their country is not supported.

I think having all currencies selected by default is a net positive.

[ghost]

OK, I'll prepare appropriate pull request.