Update currency filtering logic

[ghost]

Fixes #5300

[alkum]

ACK.

All currencies are enabled by default only for new installations, but that's fine.

[ripcurlx]

For this change I'd like to get more consensus as it will show for the initial dropdown a list with only one market that has actual offers. (AUD has some Mainnet offers)

I agree that this pre-selection is not such a big thing anymore since we have the search possibility in the combobox we haven't had in the past. Personally I'd be fine with this change if we also change the sorting in the comboxbox from sorting by name to the currency code (first column value) which is more intuitive IMO.

@chimp1984 @m52go @UX-P @leo816

[m52go]

Is there any way to sort currencies by trading activity? Maybe not real-time but even updated manually would work since the overall trends don't change very much.

[pazza83]

Is there any way to sort currencies by trading activity? Maybe not real-time but even updated manually would work since the overall trends don't change very much.

It is done in a similar way as proposed; number of current offers, in Market > Offer Book

This seems to work well. Could this be implemented for users going via Buy / Sell ?

[m52go]

Interesting. Mine appear to be sorted alphabetically in spite of having the sort-by-number-of-offers option ticked on in settings. But I do remember my drop-down looking like yours at some point in the past...so I'm not sure what's going on.

[pazza83]

@m52go

I think the option is in Setting > Preferences

Sort market lists with no. of offers / trades

[m52go]

Yes, as I said, that option is ticked on but not working for some reason...seems like a bug.

[chimp1984]

NACK

I think to spam the whole list with a multitude of currencies never traded is decreasing usability.
The related issue also do not suggest that solution but only complains inconsistency.

I think a better solution would be to show main currencies as we have, but use for the filter predicate the whole list of all currencies so that If I search for a currency which is not in the default list (or user defined list) it still is found.

[ghost]

The related issue also do not suggest that solution but only complains inconsistency.

That solution was suggested by @pazza83 in discussion on issue, however I also wasn't sure if it's the best one.

I think a better solution would be to show main currencies as we have, but use for the filter predicate the whole list of all currencies so that If I search for a currency which is not in the default list (or user defined list) it still is found.

I like it, I'll check how difficult it is to implement it that way.

[ghost]

I pushed solution suggested by @chimp1984 :

• when user type single letter default/user defined list is used for search
• when user type two or more letters list of all currencies is used for search

[chimp1984]

I pushed solution suggested by @chimp1984 :

* when user type single letter default/user defined list is used for search

* when user type two or more letters list of all currencies is used for search

I think that is confusing.
Just show the user defined list when opening the dropdown and apply the search to all currencies.

[chimp1984]

NACK

[ghost]

Just show the user defined list when opening the dropdown and apply the search to all currencies.

Fixed

[ripcurlx]

ACK - Tested it on Mainnet

All suggested changes in comments have been implemented.