Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Transaction Details and Trade ID in 'Reserved Funds', 'Locked Funds' and 'Transactions' sections in Bisq #5308

Closed
pazza83 opened this issue Mar 15, 2021 · 11 comments · Fixed by #6110

Comments

@pazza83
Copy link

pazza83 commented Mar 15, 2021

Description

The Funds section in Bisq becomes a little difficult to use when there is a large amount of transactions.

One proposal to make it more usable is to add a filter to the 'Funds' section in Bisq to able searching of; Trade IDs, Tx IDs, BTC amount.

Another suggestion is to separate transaction details and trade ID in the following sections

  • Reserved Funds
  • Locked Funds
  • Transactions

This would allow for effective sorting of columns and make it easier to sort Trade IDs and transaction details both natively in the Bisq app, but also when exporting to CSV.

Version

v1.5.9

Steps to reproduce

Try sorting by Trade ID in the above sections. You will not be able to. Want to find a specific trade ID? You will need to spend some time to do so if you have a large number of transactions.

Try exporting the above sections to a CSV file. You still will not be able to sort by trade ID without some additional work.

Expected behaviour

It should be easy to sort by trade ID.

Actual behaviour

It is impossible to sort by trade ID

Screenshots

As an example my current Bisq wallet has almost 2,500 transactions. This makes finding a specific trade ID a pain. Here is a screen shot showing the column that combines the transaction details with the Trade ID. These should be separated into two columns.

transactions2

@wallclockbuilder
Copy link
Contributor

Makes a lot of sense.
Seems obvious in hindsight.

@pazza83
Copy link
Author

pazza83 commented Mar 15, 2021

They are separate everywhere else. It is only the Funds section they have been combined for some reason.

@pazza83
Copy link
Author

pazza83 commented Apr 2, 2021

Hi @wallclockbuilder think you would be able to take this issue on?

@wallclockbuilder
Copy link
Contributor

Yes.

@pazza83
Copy link
Author

pazza83 commented Apr 2, 2021

@wallclockbuilder that is great. I just posted a lot more issues that are in need of a dev. Might be some other things you would like take on also.

@wallclockbuilder
Copy link
Contributor

Tag moi!

@pazza83
Copy link
Author

pazza83 commented Apr 2, 2021

Tag moi!

Thanks will send you a Keybase message now 👍

@pazza83
Copy link
Author

pazza83 commented May 16, 2021

Hi @wallclockbuilder how are you progressing with this issue?

@stale
Copy link

stale bot commented Aug 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Aug 21, 2021
@pazza83
Copy link
Author

pazza83 commented Aug 21, 2021

This would be good to implement still

@stale stale bot removed the was:dropped label Aug 21, 2021
@pazza83
Copy link
Author

pazza83 commented Sep 23, 2021

Hi @xyzmaker123 let me know if you would like to work on this issue.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants