Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAO out of sync causes Bisq fee to be validated incorrectly #5393

Closed
ghost opened this issue Apr 5, 2021 · 0 comments · Fixed by #5552
Closed

DAO out of sync causes Bisq fee to be validated incorrectly #5393

ghost opened this issue Apr 5, 2021 · 0 comments · Fixed by #5552

Comments

@ghost
Copy link

ghost commented Apr 5, 2021

Since 1.6.0, Bisq has had this feature to validate trading fees paid. With this model, Bisq trading partners check each other's transactions thus ensuring fees are paid (which is what keeps Bisq running).

However it is possible for a Bisq node's DAO to be out of sync and thus have a differing view on what the sufficient fee should be.

For example user Alice's node expected trading partner Bob to have paid a fee of 2.11 BSQ; in fact Bob had paid the correct fee of 1.82 BSQ. In this case Alice's node had an out of sync DAO which told them that Bob should have used a fee rate from two months ago which is higher than today's fee rate. Bisq complains to Alice that her counterparty did not pay enough fees and that a support ticket should be opened.

There are already leniency checks built onto the fee validation to allow historical fee rates. But in this case the appropriate fee rate was unknown to Alice since her DAO was stuck, and this was only evident by looking at DAO -> Dao Status screen.

The solution for Alice was to re-sync the DAO.


Ideally we would not have the situation where the DAO can silently get stuck.

Related issue: #5329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant