Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fee validation leniency using old DAO param values #5347

Merged
merged 1 commit into from Mar 24, 2021

Conversation

ghost
Copy link

@ghost ghost commented Mar 23, 2021

Some Bisq clients are stuck on an invalid DAO state and are paying fees on an old schedule.

Per #5329 (comment) : a paid fee will be considered valid if it can be derived from any of the DAO parameter changelist.

After implementing this change, the OfferBook discrepancies listed in #5329 are reduced to zero.


The essence of the leniency check is this:

image

@ripcurlx ripcurlx added this to the v1.6.0 milestone Mar 24, 2021
Copy link
Member

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK - Code looks fine.

Note for testers:
I guess the easiest/most realistic testing scenario would be to create offers with current fee on Regtest and increase it afterwards through Regtest DAO voting and check if this offer still can be taken afterwards.

@ripcurlx ripcurlx merged commit 4290613 into bisq-network:master Mar 24, 2021
@ghost ghost deleted the fee_validation_allow_old_param branch May 29, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant