Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.8.0] New user DAO sync required 4 restarts to complete #5882

Closed
ghost opened this issue Nov 30, 2021 · 4 comments · Fixed by #5894
Closed

[1.8.0] New user DAO sync required 4 restarts to complete #5882

ghost opened this issue Nov 30, 2021 · 4 comments · Fixed by #5894
Assignees

Comments

@ghost
Copy link

ghost commented Nov 30, 2021

Description

Starting Bisq v1.8.0 with a fresh data directory, the initial DAO sync threw up a reboot popup 4 times.
Logs attached.

Steps to reproduce

Run Bisq release/v1.8.0 with a fresh data directory, connect to local bitcoind.

Expected behaviour

DAO sync fast and painless.

Actual behaviour

It required restart of the app 4 times; each after the message in the log The RECIPIENT_BTC_ADDRESS is not as expected. The DAO state is probably out of sync and a resync should fix that issue

Screenshots

image

Additional info

Once the BTC chain sync completed, the DAO sync seemed to go smoothly, see log after 4th restart.
bisq.log

@ripcurlx
Copy link
Contributor

ripcurlx commented Dec 1, 2021

I saw the same with an old user directory. I haven't tried it 4 times yet, but after the second restart it is still popping up for me as well.

@ripcurlx
Copy link
Contributor

ripcurlx commented Dec 1, 2021

The address that was causing this warnings for me is 3A8Zc1XioE2HRzYfbb5P8iemCS72M6vRJV (Burningman 2). It looks like as if the fee param validation check on startup is triggered before the client was able to sync the DAO.

@ripcurlx
Copy link
Contributor

ripcurlx commented Dec 1, 2021

With a fresh user directory the initial DAO sync works just fine, but when I look at the DAO monitor it is complaining.
Bildschirmfoto 2021-12-01 um 16 06 42

What looks suspicious to me is that for block 712099 the hash is generated by the node itself, but for the next block it is taken from a Peer, which is kind of odd.

chimp1984 added a commit to chimp1984/bisq that referenced this issue Dec 4, 2021
When syncing from genesis the number of blocks are limited so we get the
`onParseBlockCompleteAfterBatchProcessing` called each time when the received
 blocks are processed, and as we are not at wallet height we repeat requesting
 blocks. But the new check for the BTC recipient triggers a resync from resource call.
We add now a check that we do this check only once the wallet is synced and our
block height from dao state matches wallet blockheight.
@chimp1984
Copy link
Contributor

chimp1984 commented Dec 4, 2021

With a fresh user directory the initial DAO sync works just fine, but when I look at the DAO monitor it is complaining.

What looks suspicious to me is that for block 712099 the hash is generated by the node itself, but for the next block it is taken from a Peer, which is kind of odd.

Could you reproduce that?

ripcurlx pushed a commit that referenced this issue Dec 7, 2021
When syncing from genesis the number of blocks are limited so we get the
`onParseBlockCompleteAfterBatchProcessing` called each time when the received
 blocks are processed, and as we are not at wallet height we repeat requesting
 blocks. But the new check for the BTC recipient triggers a resync from resource call.
We add now a check that we do this check only once the wallet is synced and our
block height from dao state matches wallet blockheight.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants