Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make account names editable for all account types #6009

Closed
pazza83 opened this issue Jan 30, 2022 · 2 comments · Fixed by #6014
Closed

Make account names editable for all account types #6009

pazza83 opened this issue Jan 30, 2022 · 2 comments · Fixed by #6014

Comments

@pazza83
Copy link

pazza83 commented Jan 30, 2022

Description

Recently @xyzmaker123 made SEPA account names editable

This was a great usability addition.

It would be good if this was extended to ALL account types (National Currency and Altcoins).

The account name is only saved and shared locally so it does not effect any trades in progress.

Version

1.8.2

Steps to reproduce

If you have a SEPA or SEPA Instant account you can change the name.

You cannot change the name for any other account type Altcoin or National Currency Account

Expected behaviour

ALL payment account type names to be editable.

Actual behaviour

Only SEPA and SEPA Instant payment account type names are editable.
@pazza83
Copy link
Author

pazza83 commented Jan 30, 2022

Hi @xyzmaker123 would you be able to take on this issue?

@ghost
Copy link

ghost commented Jan 31, 2022

Yes, I can take this task

@ghost ghost mentioned this issue Jan 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editable account names
1 participant
@pazza83