Editable account names #6014

ghost · 2022-01-31T12:20:20Z

ripcurlx · 2022-02-09T10:45:07Z

@xyzmaker123 Could you please go through all changed files for unused imports. I stopped my review after finding some in AdvanceCashForm and AmazonGiftCardForm. Not sure why Codacy didn't catch them as UnusedImports is configured 🤔 Actually I found that we have disabled most of the checks at hand. I'll re-enable them and disable them if they are not appropriate for our use cases.

ripcurlx

NACK - see #6014 (comment)

ripcurlx

NACK

Click on existing payment account
Change the account name
Click on a different payment account in list

Expected result:
Account name is reset to old name

Actual result:
Changed account name is shown in list and when selected again. It is only properly reset if you switch away e.g. to a different tab.

ripcurlx

ACK - Tested it on Regtest

w0000000t · 2022-04-27T20:33:25Z

Still erroring for me.
Go to Account > National currency accounts, click on a CBM account (or faster payments), as soon as I change the text in the name field a nullpointer exception happens.
Works no problem with Zelle Revolut and Sepa.
Excerpt from the log:

[JavaFX Application Thread] INFO  b.core.provider.fee.FeeService: BTC tx fee: txFeePerVbyte=10 minFeePerVbyte=2 
[JavaFX Application Thread] INFO  b.d.c.c.control.PopOver: hide:200.0 ms 
 [JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: Uncaught Exception from thread JavaFX Application Thread 
[JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: throwableMessage= null 
[JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: throwableClass= class java.lang.NullPointerException 
[JavaFX Application Thread] ERROR bisq.common.setup.CommonSetup: Stack trace:
java.lang.NullPointerException
	at bisq.desktop.components.paymentmethods.FasterPaymentsForm.updateAllInputsValid(FasterPaymentsForm.java:137)
	at bisq.desktop.components.paymentmethods.PaymentMethodForm.lambda$addAccountNameTextFieldWithAutoFillToggleButton$1(PaymentMethodForm.java:136)
	at com.sun.javafx.binding.ExpressionHelper$Generic.fireValueChangedEvent(ExpressionHelper.java:360)
	at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80)
	at javafx.scene.control.TextInputControl$TextProperty.fireValueChangedEvent(TextInputControl.java:1459)
	at javafx.scene.control.TextInputControl$TextProperty.markInvalid(TextInputControl.java:1463)
	at javafx.scene.control.TextInputControl$TextProperty.controlContentHasChanged(TextInputControl.java:1402)
	at javafx.scene.control.TextInputControl.lambda$new$0(TextInputControl.java:146)
	at com.sun.javafx.binding.ExpressionHelper$SingleInvalidation.fireValueChangedEvent(ExpressionHelper.java:136)
	at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80)
	at javafx.scene.control.TextField$TextFieldContent.insert(TextField.java:91)
	at javafx.scene.control.TextInputControl.replaceText(TextInputControl.java:1264)
	at javafx.scene.control.TextInputControl.updateContent(TextInputControl.java:572)
	at javafx.scene.control.TextInputControl.replaceText(TextInputControl.java:564)
	at javafx.scene.control.skin.TextFieldSkin.replaceText(TextFieldSkin.java:450)
	at com.sun.javafx.scene.control.behavior.TextFieldBehavior.replaceText(TextFieldBehavior.java:179)
	at com.sun.javafx.scene.control.behavior.TextInputControlBehavior.defaultKeyTyped(TextInputControlBehavior.java:402)
	at com.sun.javafx.scene.control.behavior.TextInputControlBehavior.lambda$keyMapping$62(TextInputControlBehavior.java:332)
	at com.sun.javafx.scene.control.inputmap.InputMap.handle(InputMap.java:274)
	at com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(CompositeEventHandler.java:247)
	at com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:80)
	at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:234)
	at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)
	at com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74)
	at com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:54)
	at javafx.event.Event.fireEvent(Event.java:198)
	at javafx.scene.Scene$KeyHandler.process(Scene.java:4064)
	at javafx.scene.Scene.processKeyEvent(Scene.java:2123)
	at javafx.scene.Scene$ScenePeerListener.keyEvent(Scene.java:2591)
	at com.sun.javafx.tk.quantum.GlassViewEventHandler$KeyEventNotification.run(GlassViewEventHandler.java:217)
	at com.sun.javafx.tk.quantum.GlassViewEventHandler$KeyEventNotification.run(GlassViewEventHandler.java:149)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleKeyEvent$1(GlassViewEventHandler.java:248)
	at com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(QuantumToolkit.java:412)
	at com.sun.javafx.tk.quantum.GlassViewEventHandler.handleKeyEvent(GlassViewEventHandler.java:247)
	at com.sun.glass.ui.View.handleKeyEvent(View.java:547)
	at com.sun.glass.ui.View.notifyKey(View.java:971)
	at com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
	at com.sun.glass.ui.gtk.GtkApplication.lambda$runLoop$11(GtkApplication.java:277)
	at java.base/java.lang.Thread.run(Thread.java:834)
 
java.lang.NullPointerException
	at bisq.desktop.components.paymentmethods.FasterPaymentsForm.updateAllInputsValid(FasterPaymentsForm.java:137)
	at bisq.desktop.components.paymentmethods.PaymentMethodForm.lambda$addAccountNameTextFieldWithAutoFillToggleButton$1(PaymentMethodForm.java:136)
	at com.sun.javafx.binding.ExpressionHelper$Generic.fireValueChangedEvent(ExpressionHelper.java:360)
	at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80)
	at javafx.scene.control.TextInputControl$TextProperty.fireValueChangedEvent(TextInputControl.java:1459)
	at javafx.scene.control.TextInputControl$TextProperty.markInvalid(TextInputControl.java:1463)
	at javafx.scene.control.TextInputControl$TextProperty.controlContentHasChanged(TextInputControl.java:1402)
	at javafx.scene.control.TextInputControl.lambda$new$0(TextInputControl.java:146)
	at com.sun.javafx.binding.ExpressionHelper$SingleInvalidation.fireValueChangedEvent(ExpressionHelper.java:136)
	at com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80)
	at javafx.scene.control.TextField$TextFieldContent.insert(TextField.java:91)
	at javafx.scene.control.TextInputControl.replaceText(TextInputControl.java:1264)
	at javafx.scene.control.TextInputControl.updateContent(TextInputControl.java:572)
	at javafx.scene.control.TextInputControl.replaceText(TextInputControl.java:564)
	at javafx.scene.control.skin.TextFieldSkin.replaceText(TextFieldSkin.java:450)
	at com.sun.javafx.scene.control.behavior.TextFieldBehavior.replaceText(TextFieldBehavior.java:179)
	at com.sun.javafx.scene.control.behavior.TextInputControlBehavior.defaultKeyTyped(TextInputControlBehavior.java:402)
	at com.sun.javafx.scene.control.behavior.TextInputControlBehavior.lambda$keyMapping$62(TextInputControlBehavior.java:332)
	at com.sun.javafx.scene.control.inputmap.InputMap.handle(InputMap.java:274)
	at com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(CompositeEventHandler.java:247)
	at com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:80)
	at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:234)
	at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191)
	at com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56)
	at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114)
	at com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74)
	at com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:54)
	at javafx.event.Event.fireEvent(Event.java:198)
	at javafx.scene.Scene$KeyHandler.process(Scene.java:4064)
	at javafx.scene.Scene.processKeyEvent(Scene.java:2123)
	at javafx.scene.Scene$ScenePeerListener.keyEvent(Scene.java:2591)
	at com.sun.javafx.tk.quantum.GlassViewEventHandler$KeyEventNotification.run(GlassViewEventHandler.java:217)
	at com.sun.javafx.tk.quantum.GlassViewEventHandler$KeyEventNotification.run(GlassViewEventHandler.java:149)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleKeyEvent$1(GlassViewEventHandler.java:248)
	at com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(QuantumToolkit.java:412)
	at com.sun.javafx.tk.quantum.GlassViewEventHandler.handleKeyEvent(GlassViewEventHandler.java:247)
	at com.sun.glass.ui.View.handleKeyEvent(View.java:547)
	at com.sun.glass.ui.View.notifyKey(View.java:971)
	at com.sun.glass.ui.gtk.GtkApplication._runLoop(Native Method)
	at com.sun.glass.ui.gtk.GtkApplication.lambda$runLoop$11(GtkApplication.java:277)
	at java.base/java.lang.Thread.run(Thread.java:834)

ripcurlx suggested changes Feb 9, 2022

View reviewed changes

boring-cyborg bot added in:altcoins is:no-priority PR or issue marked with this label is not up for compensation right now labels Feb 9, 2022

ghost requested a review from ripcurlx February 9, 2022 11:28

ghost mentioned this pull request Feb 15, 2022

For cycle 33 bisq-network/compensation#998

Closed

ripcurlx added this to the v1.8.4 milestone Feb 17, 2022

ripcurlx mentioned this pull request Feb 23, 2022

For Cycle 33 bisq-network/compensation#1016

Closed

ripcurlx suggested changes Feb 28, 2022

View reviewed changes

xyzmaker123 added 5 commits February 28, 2022 13:53

Edit account names - refactor method name

e8ee3fa

Edit account names - altcoin forms

702a31f

Edit account names - fiat forms

01b1512

Optimize imports

e6320cd

Fix: revert account name on change selected account

fcbe3cb

ghost requested a review from ripcurlx February 28, 2022 14:54

ripcurlx approved these changes Mar 9, 2022

View reviewed changes

ripcurlx merged commit 0ea70dc into bisq-network:master Mar 9, 2022

ghost mentioned this pull request Mar 25, 2022

For Cycle 34 bisq-network/compensation#1035

Closed

ghost mentioned this pull request Apr 28, 2022

Fix NPE on edition of CBM FasterPayments and USPostal accounts #6177

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Editable account names #6014

Editable account names #6014

ghost commented Jan 31, 2022

ripcurlx commented Feb 9, 2022

ripcurlx left a comment

ripcurlx left a comment

ripcurlx left a comment

w0000000t commented Apr 27, 2022

Editable account names #6014

Editable account names #6014

Conversation

ghost commented Jan 31, 2022

ripcurlx commented Feb 9, 2022

ripcurlx left a comment

Choose a reason for hiding this comment

ripcurlx left a comment

Choose a reason for hiding this comment

ripcurlx left a comment

Choose a reason for hiding this comment

w0000000t commented Apr 27, 2022