Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework recent changes to dependency verification #1563

Merged
merged 3 commits into from Jun 22, 2018
Merged

Rework recent changes to dependency verification #1563

merged 3 commits into from Jun 22, 2018

Commits on Jun 5, 2018

  1. Revert "Update build.gradle to fix failing checksum tests" 

    This reverts commit 175e11d.
    @cbeams
    cbeams committed Jun 5, 2018
    Copy the full SHA
    536d13f View commit details
    Browse the repository at this point in the history

  2. Update libdohj and bitcoinj dependency verification hashes 

    This does the work that was intended to be done in commit
175e11d, but was done by first removing
the dependencyVerification block entirely, and then replacing it with
the output of the `calculateChecksums` task.

The entire process went like this:

 1. Remove existing dependencyVerification block from build.gradle
 2. Run `./gradlew -q calculateChecksums | grep -v network.bisq:bisq- >> build.gradle`
 3. Run `git diff` to see that only the checksums we expect to have
    changed have in fact changed (libdohj and bitcoinj in this case).
 4. Commit the changes (in this commit)

I'll update the instructions for the dependencyVerification block in a
subsequent commit to make this clearer in the future.
    @cbeams
    cbeams committed Jun 5, 2018
    Copy the full SHA
    ba1419a View commit details
    Browse the repository at this point in the history

  3. Update instructions for regenerating dependency verification hashes

    @cbeams
    cbeams committed Jun 5, 2018
    Copy the full SHA
    6467b55 View commit details
    Browse the repository at this point in the history