Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle unknown PB data from encrypted messages #1581

Merged
merged 1 commit into from Jun 22, 2018
Merged

Handle unknown PB data from encrypted messages #1581

merged 1 commit into from Jun 22, 2018

Commits on Jun 22, 2018

  1. Handle unknown PB data from encrypted messages 

    - Use ProtobufferException for
CoreNetworkProtoResolver.fromProto(PB.NetworkEnvelope proto)
- Add raw PB data in case if an exception
- log error if the encrypted data contains unknown PB data

Note: We should refactor the resolvers with checked exceptions instead
of the ProtobufferRuntimeException, but for the moment we leave that to
not add too much complexity/risk for that release.
    @ManfredKarrer
    ManfredKarrer committed Jun 22, 2018
    Configuration menu
    Copy the full SHA
    68c4089 View commit details
    Browse the repository at this point in the history