Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Redesign #1700

Closed
wants to merge 112 commits into from
Closed

[WIP] Redesign #1700

wants to merge 112 commits into from

Conversation

ripcurlx
Copy link
Member

@ripcurlx ripcurlx commented Sep 19, 2018

I've created this pull request to keep everyone up-to-date on the redesign progress and to push myself a little bit to get it done as quickly as possible 😉

Open Tasks

  • Check all forms to use material design style
    • Fiat Account View - Add new account
    • Altcoin Account View - Add new account
  • Show currency label also if there are no offers available (OfferBook, OfferBookChart,...)
  • Check if rendering intensive views can be delayed not to conflict with ripple effect in e.g. tabs
  • Fix height in Offer Book View to prevent scrollbar
  • Adapt Create Offer screen, that there won't be scrolling necessary
  • Use ButtonBar for all buttons to have consistent positioning
  • Show error below TextField instead of a popup
  • Fix ComboBox selected values not shown in some cases
  • Use tabs in account section instead of toggle button group left
  • Style Date Picker

Optional

  • Add ripple effect for main navigation
  • Clean up css colors
  • Clean up css classes

@ManfredKarrer
Copy link
Member

@ripcurlx As discussed on phone I created a release branch and merged that PR into it. Can you close that PR and make new PRs to the release branch?

@ManfredKarrer
Copy link
Member

Merged into release-candidate-0.9.0 branch.

@cbeams
Copy link
Member

cbeams commented Nov 2, 2018

@ripcurlx, now that this PR is closed, what is the best way to provide feedback on the redesign before we merge and release the 0.9.0 branch?

I ran through the app from the head of the release-candidate-0.9.0 branch earlier today and found a number of UI issues. Mostly minor stuff like spacing, placement of drop-down menus, etc., but some more significant things, too, like restyling the Trades graph to match the style of the Offer Book graph. Do you have a TODO list somewhere that already includes these things? I don't want to spam you with a bunch of stuff you already know about and already plan to fix.

@ManfredKarrer
Copy link
Member

@cbeams It is still too early for feedback...too much open known stuff by ourself... but yes the release candidate is where the latest code is in. As soon @ripcurlx is ready we will do a cross check with @pedromvpg and then ask for review and testing. Might take another week...

@cbeams
Copy link
Member

cbeams commented Nov 2, 2018

Perfect, thanks.

@ripcurlx
Copy link
Member Author

ripcurlx commented Nov 2, 2018

@cbeams I created an issue, which I'll update on the go until we are ready for a bigger testing cycle.

@ripcurlx ripcurlx deleted the redesign branch December 18, 2019 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants