Dao ui improvements #1751
Dao ui improvements #1751
Conversation
Default ComboBox does not show promptText after clear selection. https://stackoverflow.com/questions/50569330/how-to-reset-combobox-and-display-prompttext?noredirect=1&lq=1
- Add COMPENSATION_REQUEST_MIN_AMOUNT and COMPENSATION_REQUEST_MAX_AMOUNT As BSQ based validation values can change over time if BSQ value rise we need to support that in the Params as well. - Add validateParamValue to ChangeParamValidator
- Show current formatted value - Parse input to correct domain value - Add validation (WIP) - Add boundary checks (WIP)
core/src/main/java/bisq/core/dao/governance/proposal/compensation/CompensationConsensus.java
Outdated
Show resolved
Hide resolved
| break; | ||
| case BLIND_VOTE_FEE: | ||
| break; | ||
| case COMPENSATION_REQUEST_MIN_AMOUNT: |
There was a problem hiding this comment.
There should also be a check that COMPENSATION_REQUEST_MIN_AMOUNT < COMPENSATION_REQUEST_MAX_AMOUNT, both current and proposed.
There was a problem hiding this comment.
Yes the validations are very much WIP...
| @VisibleForTesting | ||
| long getNewValueByPercentChange(Param param, long percentChange) { | ||
| checkArgument(percentChange > -100, "percentChange must be bigger than -100"); | ||
| return (getCurrentValue(param) * 100 * (100 + percentChange)) / 100; |
There was a problem hiding this comment.
This multiplies by 100 one time too many.
|
The validation code for params is WIP and I am not sure if the current implementation is intuitive (range set by % of current value...). I will keep that for a bit later and try to get other high prio stuff done first. But feel free to work on that if you want. |
- Use DAO Params to get the trade fees - Rename existing params - Add min fee values
| ObservableList<BlindVotePayload> appendOnlyStoreList = blindVoteListService.getAppendOnlyStoreList(); | ||
| appendOnlyStoreList | ||
| .forEach(blindVotePayload -> { | ||
| // We want a random delay between 0.1 and 30 sec. depending on the number of items |
There was a problem hiding this comment.
What's the reason to depend on the number of items?
There was a problem hiding this comment.
We don't want to stress the network with many broadcasts, so if there are many objects it will be delayed, the more objects the longer the dealy, but not more then 30 sec.
No description provided.