Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OpenJDK10 in Travis CI builds #1792

Closed
wants to merge 2 commits into from
Closed

Conversation

cbeams
Copy link
Member

@cbeams cbeams commented Oct 19, 2018

Following OracleJDK10's EOL this month, and subsequent removal of
downloads. See
https://docs.travis-ci.com/user/languages/java/#using-java-10-and-later
for details.

@cbeams
Copy link
Member Author

cbeams commented Oct 19, 2018

@ManfredKarrer, @ripcurlx, @devinbileck, I took a quick stab at this, and (as expected), the builds are breaking on not having JavaFX available. I'm sure there's some way to sort this out, but I just had a few minutes here. Somebody can pick up the thread if they like, or it may just be easier in the end to upgrade to (Oracle)JDK11. It would be nice to be on OpenJDK anyway, but if it's too much hassle, perhaps that's a task that somebody can pick up later.

Anyway, feel free to continue hacking on this PR, or to just close it. I'm not sure if I'll be able to get back to it soon.

@ripcurlx
Copy link
Member

Yes, unfortunately both for openJDK and Oracle JDK11 we need to integrate https://openjfx.io/ separately. It didn't work for me out-of-the-box so I stopped it atm. For JDK11 we also have to wait for the next gradle release as JDK11 is not supported yet. Last release candidate doesn't have the latest fixes included. I hoped we could delay the switch to JDK11 after the next release, but if JDK10 is not supported on Travis anymore we might not have a choice.

@devinbileck
Copy link
Member

Based on their GitHub, Gradle 5.0 has a target date of Oct 31 (https://github.com/gradle/gradle/milestone/48). So switching to JDK11 may have to wait until then. For now, we will likely need to get OpenJDK10 working. I will spend some time trying to get this going.

@devinbileck
Copy link
Member

I ended up creating a new PR as I don't believe I have push access to this.
#1794

@cbeams
Copy link
Member Author

cbeams commented Oct 20, 2018

Closing as superseded by #1794.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants