[WIP] Prepare http api merge #1797
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove BalanceModel and add Balances and BalanceUtil - Move setup code from BisqSetup to domains
- rewrite fee estimation for trade fee transactions - Remove preferences.getPayFeeInBtc call and use isPayFeeInBtc (delegate) instead
|
As much time has passed without review, that PR is quite outdated now and would require a merge with upstream and careful check if all is still correct. I added a WIP to reflect that its not ready to merge as it is. |
|
This PR can be closed as it's changes have been incorporated into #2156 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds changes from the Http-API branch which have been applied there for a while but not well tested and reviewed. After that is merged it should make meging the Http-API branch easier.
It does not contain Http-API content beside the option keys.