Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove java 9 module configuration #1805

Merged

Conversation

ripcurlx
Copy link
Member

@ripcurlx ripcurlx commented Oct 23, 2018

Remove java 9 module configuration for openjfx libraries as they are used regularily during compile time.

@ripcurlx ripcurlx changed the title Remove java 9 module configuration for openjfx libraries as they are used regularily during compile time Remove java 9 module configuration Oct 23, 2018
@ripcurlx
Copy link
Member Author

@devinbileck I've also ran it with OpenJDK now locally and everything looks fine!
@ManfredKarrer The only thing I need to test is a trade, but atm my local Regtest setup is not working anymore as the client is not able to connect to the local Bitcoin Core node over Regtest.

Copy link
Member

@devinbileck devinbileck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ripcurlx ripcurlx merged commit 62b4b59 into bisq-network:master Oct 23, 2018
@ManfredKarrer
Copy link
Member

@ripcurlx Re regtest: just delete all data dirs also from bitcoin core regtest (exclude bitcoin.conf from delete).

@ripcurlx ripcurlx deleted the remove-unnecessary-java-module-config branch December 18, 2019 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants