Verifi dao param default vals #1769 #1820
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First approach, limited by a factor variable. Tests up and running.
First approach, limited by a factor variable. Tests up and running.
New, more intuitive methods for testing min and max values of proposed DAO parameters. Unit tests also provided. Next up will be a discussion of what limits each parameter should have. First part of issue: bisq-network#1769
New, more intuitive methods for testing min and max values of proposed DAO parameters. Unit tests also provided. Next up will be a discussion of what limits each parameter should have. First part of issue: bisq-network#1769
|
a little too fast... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surrounding code for DAO param validation
New, more intuitive methods for testing min and max values of proposed DAO parameters.
Unit tests also provided.
Next up will be a discussion of what limits each parameter should have.
First part of issue: #1769