Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fiat amount to fee #1827

Conversation

ManfredKarrer
Copy link
Member

Please see the screenshot in the slack #design channel. Not 100% sure if that solution is really good...

@ripcurlx
Copy link
Member

I'm not so sure if it is a good idea to put the values into an InputField style box if you can't change them. What about putting it together with the security deposit in an advanced options section that can be hidden/shown based on a preferences flag?
trade fees
This on the other hand makes it still confusing for the first time user. Maybe we could add another step where you have to select the trade fee currency once and your setting is stored. The only way to change it is by activating advanced options in the preferences and/or being able to set the trade fee currency in the preferences as well.

@ManfredKarrer
Copy link
Member Author

Great thanks, yes much better. But also agree that it still is confusing. We still have time as it will be only relevant for the DAO mainnet launch. Before that there would be only displayed the fee in BTC and Fiat and %.
As you observed that PR was already part in another merged PR (was not intended) so I will close that. Feel free to add your changes to your follow up PRs!

@ManfredKarrer
Copy link
Member Author

Close as it was already merged as part of another PR

@ManfredKarrer ManfredKarrer deleted the add-fiat-amount-to-fee branch October 31, 2018 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants