List Mask (MASK)

[diablax]

• Official project URL: https://mask.team
• Official block explorer URL: http://explorer.mask.team

[cbeams]

NACK. Squash to a single commit per instructions at https://bisq.network/list-asset, and use blank lines per convention in import statements for the Mask class.

[diablax]

squashed and imports fixed.

[cbeams]

From https://docs.bisq.network/exchange/howto/list-asset.html#step-5-create-a-well-formed-git-commit:

[diablax]

My apologies Chris, I have now added the changes.

[cbeams]

NACK, per suggested formatting changes.

[diablax]

Again, apologies. Did not notice these messy lines on nano, perhaps they were formatted differently on my machine.

[diablax]

Let me know if there is anything else to do.

[cbeams]

From https://docs.bisq.network/exchange/howto/list-asset.html#step-6-submit-your-pull-request

The reason I need this is to clean up the body of your commit. You squashed it, but left all the comments from the squashed commits in the body of the remaining commit. The body should be empty. You can do that yourself and force push, or give me rights to do it. I'll merge afterward.

[diablax]

Feel free to amend. Edits are enabled.

[diablax]

Would it be easier to just submit a new PR?

[diablax]

I have cleaned up the code and will resubmit PR to comply with the rules.

[cbeams]

Please just reopen this PR with a force-pushed cleaned up version of your commit. There's no need to open a new PR.

[cbeams]

Wait. This PR now shows 2,085 files changed. Go ahead and resubmit unless you know how to fix that. Note that you submitted this PR from your master branch, which is something we ask you not to do in the instructions as well. This may be the source of the problem, especially if you pulled recent changes to upstream master.

[cbeams]

It's because you deleted your fork of the repository.

[diablax]

Yes I will resubmit everything properly and make sure it is on a different branch. Apologies for taking up so much of your time.