Complete bond domain and views #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enums must not be used directly for hashCode or equals as it delivers the Object.hashCode (internal address)! The equals and hashCode methods cannot be overwritten in Enums. It was only applied to classed which are used as value objects and potentially are used in Sets or other context which involve usage of equals or hashCode
- We store the bonded roles in the evaluated proposals in the dao state. From there we can get the bonded role object as it is part of the bonded role proposal. Though we need to take that data immutable (next commit will handle that)
Use BondedRoleState to hold the mutable data. Store the BondedRoleState in a local map.
This is the first of a series of renaming commits. We want to use role for the immutable class and BondedRole for the wrapper which contains role and the mutable state.
Add ImmutableDaoStateVo interface to mark the objects used in the daoState as immutable.
- we want to have only those classes in the daoState package which are stored in the daoState and immutable
That was a big commit with restructuring the packages and classes. Motivation was to isolate the daoState value objects so it is more clear which data are help in the daoState. As it was hard to keep an overview and easy to add mutable data I think that makes it more safe overall. I am aware that the downside to take out domain models from the domain packages is not so nice. Also moved blockchain models to parser and full node packages.
That was a big commit with restructuring the packages and classes. Motivation was to isolate the daoState value objects so it is more clear which data are help in the daoState. As it was hard to keep an overview and easy to add mutable data I think that makes it more safe overall. I am aware that the downside to take out domain models from the domain packages is not so nice. Also moved blockchain models to parser and full node packages.
That was a big commit with restructuring the packages and classes. Motivation was to isolate the daoState value objects so it is more clear which data are help in the daoState. As it was hard to keep an overview and easy to add mutable data I think that makes it more safe overall. I am aware that the downside to take out domain models from the domain packages is not so nice. Also moved blockchain models to parser and full node packages.
- Add BondedRoleState to reflect all diff. states. - Show in UI correct state and button state for lockup/revoke - Rename ProposalService classes to ProposalFactory
- To avoid that we handle lockup/unlock 2 times in the view we will remove the generic options (upcoming commits...)
Still WIP with many areas...
sqrrm
reviewed
Nov 10, 2018
| } | ||
|
|
||
| public boolean isConfiscatedUnlockTxOutput(String unlockTxId) { |
There was a problem hiding this comment.
What is the motivation to do confiscation on both lockupTxOutput and unlockTxOutput? Wouldn't it be clearer to only use the lockupTxOutput for confiscation?
There was a problem hiding this comment.
If the user has created already the unlock tx confiscating the lockup txo will not have any effect. For identifying we use the lockup tx.
But after a second thought, you might be right. If the lockup txo is confiscated all follow up are invalid anyway. Need to check again and see if we are filtering by unspent state...
Would need more testing anyway...
There was a problem hiding this comment.
That's what I was thinking, no point in targeting the individual unlock tx since the bsq is already confiscated in the lockup. But perhaps it's needed to mark the unlock txouput as confiscated at the point of parsing the vote result if it's already being unlocked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.