Fixed netlayer and tor binary dependency issues #1917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
netlayer had and has a well-hidden build configuration issue since version 0.4.2. It always fetches the "master" binaries instead of the binaries of the respective release. although until recently, bisq wanted to use 0.4.2, has actually used 0.4.9pre-draft already. Due to changes in netlayer and its upcoming release, the netlayer build configuration has changed and thus, the issue showed itself. (at least we now know that Netlayer 0.4.9pre still works with bisq :) )
This fixes the issue temporarily.
I am currently working on getting the binaries of TorBrowser 8.0.3 (out for a month or so) into bisq. so IMHO this temporary fix is GEFN