Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitattributes #1927

Merged
merged 3 commits into from Nov 20, 2018
Merged

Add gitattributes #1927

merged 3 commits into from Nov 20, 2018

Conversation

devinbileck
Copy link
Member

Adding a .gitattributes file will ensure that text files that any contributor introduces to the repository have their line endings normalized. This is in reaction to the issue discussed at bisq-network/gradle-witness#1 (comment) while trying to generate reproducible builds.

@ManfredKarrer
Copy link
Member

I leave that for @cbeams ...

This is specifically for the gradlew.bat file generated by the `gradle
wrapper` command. Typically, this file should never be edited, but just
in case it is, this configuration will preserve its original CRLF line
endings.
Copy link
Member

@cbeams cbeams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. I've added an additional commit to make our .editorconfig match these .gitattribute settings with regard to .bat files.

@cbeams cbeams merged commit 9f4f5c4 into bisq-network:master Nov 20, 2018
cbeams added a commit that referenced this pull request Nov 20, 2018
@devinbileck devinbileck deleted the add-gitattributes branch November 20, 2018 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants