Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added script to install Java SE 10 target platform on OS rpm based #2024

Merged
merged 1 commit into from Dec 2, 2018

Conversation

albpal
Copy link

@albpal albpal commented Dec 1, 2018

Easy script to install the required java and perform ./gradlew build after that.

Copy link
Member

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ManfredKarrer
Copy link
Member

@devinbileck Maybe you can have a look as well?

@devinbileck
Copy link
Member

utACK
Looks fine to me. However, with only one line that differs from the other script, it should really be handled within a single script - less duplication and maintenance required.

@ManfredKarrer
Copy link
Member

@devinbileck Agree. Would you be able to make that merged scipt (after release)?

@devinbileck
Copy link
Member

@ManfredKarrer yep I can clean that up later.

@ManfredKarrer
Copy link
Member

@devinbileck Thanks. I will merge it in and later we consolidate those 2 files.

@ManfredKarrer ManfredKarrer merged commit d0d1cd5 into bisq-network:master Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants