Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script for easy installation and configuration of the necessary JDK on Windows #2039

Merged
merged 2 commits into from Dec 4, 2018
Merged

Add script for easy installation and configuration of the necessary JDK on Windows #2039

merged 2 commits into from Dec 4, 2018

Conversation

devinbileck
Copy link
Member

No description provided.

@devinbileck
Add install_java.bat
0dc924b 
This batch file allows for easy installation and configuration of the necessary JDK on Windows.
@devinbileck
Update build.md to mention scripts directory
24aaf24
ManfredKarrer
ManfredKarrer approved these changes Dec 4, 2018
View reviewed changes
Copy link
Member

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Java 10 accessible still without registering at the (buggy) Oracle page?

I am not experiences with Windows scripting, so maybe someone else can review as well...
Otherwise utACK from me.

@ripcurlx
Copy link
Member

ripcurlx commented Dec 4, 2018

utACK - @ManfredKarrer It is just for OpenJDK, so there shouldn't be an issue with Oracle.

@ripcurlx ripcurlx merged commit b16d75f into bisq-network:master Dec 4, 2018
@devinbileck devinbileck deleted the install_java.bat branch December 4, 2018 20:19
@devinbileck devinbileck mentioned this pull request Dec 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManfredKarrer ManfredKarrer ManfredKarrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devinbileck @ripcurlx @ManfredKarrer