Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List Noir(NOR) #2175

Merged
merged 3 commits into from Jan 7, 2019
Merged

List Noir(NOR) #2175

merged 3 commits into from Jan 7, 2019

Conversation

flo071
Copy link
Contributor

@flo071 flo071 commented Dec 27, 2018

blabno
blabno suggested changes Jan 7, 2019
View reviewed changes
Copy link

@blabno blabno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK squash commits into a single one.

assets/src/main/java/bisq/asset/coins/Noir.java
public Noir() {
super("Noir", "NOR", new RegexAddressValidator("^[Z][_A-z0-9]*([_A-z0-9])*$"));
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline

assets/src/test/java/bisq/asset/coins/NoirTest.java
assertInvalidAddress("ZHoMM3vccwGrAQocmmp9ZHA7Gjg9Uqkok7*");
assertInvalidAddress("ZHoMM3vccwGrAQocmmp9ZHA7Gjg9Uqkok7#jHt5jtP");
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing newline

@ManfredKarrer ManfredKarrer merged commit b61a396 into bisq-network:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blabno blabno blabno requested changes

Assignees
No one assigned
Labels
in:altcoins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flo071 @blabno @ManfredKarrer