List Cash2 (CASH2) #2281
Closed
List Cash2 (CASH2) #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aphivantrakul
commented
Jan 17, 2019
aphivantrakul
commented
- Official project URL: https://cash2.org
- Official block explorer URL: https://blocks.cash2.org
…into blabno-minimal-http-api
- Official project URL: https://cash2.org - Official block explorer URL: https://blocks.cash2.org
- Rename BisqSetupCompleteListener to BisqSetupListener - Add onInitP2pNetwork and onInitWallet to BisqSetupListener - make onInitP2pNetwork and onInitWallet default so no impl. required
- Add onInitWallet to HttpApiMain and start http server there - Add onRequestWalletPassword to BisqSetupListener - Override setupHandlers in HttpApiHeadlessApp and adjust setRequestWalletPasswordHandler (impl. missing) - Add onRequestWalletPassword to HttpApiMain
…tarted Start api before wallet started
blabno
reviewed
Jan 22, 2019
There was a problem hiding this comment.
This asset uses Cryptonote validator. Shouldn't it include similar messages as Monero?
Trading XMR on Bisq requires that you understand and fulfill \
the following requirements:\n\n\
For sending XMR, you need to use either the official Monero GUI wallet or Monero CLI wallet with the \
store-tx-info flag enabled (default in new versions). Please be sure you can access the tx key as \
that would be required in case of a dispute.\n\
monero-wallet-cli (use the command get_tx_key)\n\
monero-wallet-gui (go to history tab and click on the (P) button for payment proof)\n\n\
In addition to XMR checktx tool (https://xmr.llcoins.net/checktx.html) verification can also be accomplished in-wallet.\n\
monero-wallet-cli : using command (check_tx_key).\n\
monero-wallet-gui : on the Advanced > Prove/Check page.\n\
At normal block explorers the transfer is not verifiable.\n\n\
You need to provide the arbitrator the following data in case of a dispute:\n\
- The tx private key\n\
- The transaction hash\n\
- The recipient's public address\n\n\
Failure to provide the above data, or if you used an incompatible wallet, will result in losing the \
dispute case. The XMR sender is responsible for providing verification of the XMR transfer to the \
arbitrator in case of a dispute.\n\n\
There is no payment ID required, just the normal public address.\n\
If you are not sure about that process visit (https://www.getmonero.org/resources/user-guides/prove-payment.html) \
or the Monero forum (https://forum.getmonero.org) to find more information.
|
Hello and thank you for looking into my pull request. Yes, I agree that a similar message should be included. Do you know where I can include it and how it should be done? |
|
Have a look at Blur: 7e9bc1f#diff-ef294f386c27fc762baf4c55e8b33e53 |
Added pop up message to warn Cash2 sellers that the transaction hash, transaction secret key, and the receiver's Cash2 address are required fromt the seller in the event of a trade dispute that goes to arbitration.
|
Hello, I am sorry but it looks like things got kind of messed up in this commit. I was getting merge conflict errors, so I updated my branch from the master branch. It seems now that I am getting a build error that is not related to the code I am trying to add. Do you have suggestions on how I can fix this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.