Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libdohj dependency #2368

merged 1 commit into from Feb 5, 2019


None yet
3 participants
Copy link

oscarguindzberg commented Feb 4, 2019

Remove libdohj dependency and the code to use LTC, DASH or DOGE as base currencies.

@@ -90,8 +88,8 @@ void init(@Nullable Consumer<String> chainFileLockedExceptionHandler,
Runnable walletPasswordHandler,
Runnable downloadCompleteHandler,
Runnable walletInitializedHandler) {"Initialize WalletAppSetup with BitcoinJ version {} and LibDohJ version {} with hash of BitcoinJ commit {}",
VersionMessage.BITCOINJ_VERSION, Version.VERSION, Version.BITCOINJ_VERSION);"Initialize WalletAppSetup with BitcoinJ version and hash of BitcoinJ commit {}",

This comment has been minimized.


ManfredKarrer Feb 4, 2019


I think here is missing the {} -> BitcoinJ version {} and

This comment has been minimized.


ManfredKarrer Feb 4, 2019


Beside that, ACK (just tested).

This comment has been minimized.


oscarguindzberg Feb 5, 2019

Author Contributor

Done. just force pushed the fix.

@ManfredKarrer ManfredKarrer requested review from ripcurlx and removed request for ripcurlx and cbeams Feb 4, 2019

Copy link

ripcurlx left a comment

ACK - besides the small change requested by @ManfredKarrer

@oscarguindzberg oscarguindzberg force-pushed the oscarguindzberg:remove-libdohj branch from f08e174 to 52e3618 Feb 5, 2019

Copy link

ManfredKarrer left a comment


@ManfredKarrer ManfredKarrer merged commit 67b2555 into bisq-network:master Feb 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

@oscarguindzberg oscarguindzberg deleted the oscarguindzberg:remove-libdohj branch Feb 7, 2019

@ripcurlx ripcurlx referenced this pull request Feb 26, 2019


For February 2019 #224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.