Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning for bonded role if user has insufficient funds #2386

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
2 participants
@ripcurlx
Copy link
Member

ripcurlx commented Feb 7, 2019

Fixes #2307.

@ripcurlx ripcurlx requested a review from ManfredKarrer as a code owner Feb 7, 2019

@ripcurlx ripcurlx added the in:dao label Feb 7, 2019

@ManfredKarrer ManfredKarrer requested a review from sqrrm Feb 9, 2019

@sqrrm

sqrrm approved these changes Feb 10, 2019

Copy link
Member

sqrrm left a comment

ACK

This is better than not showing a warning but since it uses getAvailableBalance from bsqWalletService it will only know about acked funds and would warn if some BSQ are pending. I don't have a solution for that yet though, it turned out to be not trivial.

@ripcurlx ripcurlx merged commit a47f1de into bisq-network:master Feb 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ripcurlx ripcurlx referenced this pull request Feb 27, 2019

Closed

For February 2019 #224

@sqrrm sqrrm referenced this pull request Feb 28, 2019

Closed

For February 2019 #228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.