Add hash of dao state #2532
Merged
Add hash of dao state #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to have a deterministic dao state. The PubKeyScript in the TxOutput was the only optional field which was only set in the dumpBlockchainData program argument was set as it was only required for the json dump for the explorer. It has 50 bytes of data which is about 20% of the txOutput data size. We prefer atm to avoid additional complexity which would be created if we would handle that optional field (e.g. exclude from hash creation). The property might be useful as well for other use cases in future.
We create a chain of hashes of the dao state starting from the genesis block height and using the previous hash in the hash. This ensures that the history need to be correct if a particular hash at a block height is correct. We request from seed nodes the last 10 hashes and broadcast to our peers our hash at each new block. We build our list in memory and listen on the new onSnapShotApplied event to start building our chain from the genesis height up to the last snapshot block and after that from each parsed block. If we detect a mismatch we store it in a collection and the UI can show a warning to the user. We added also the onDaoStateChanged handler to the DaoStateListener. This event is called after all parsing is completed and listeners have completed their work. We must not use time based delays in the listener code otherwise we would get changed our dao state after that event. To detect such we added a assert method to throw an exception if the dao state gets changed after the allowDaoStateChange is set to false.
Add parseBlockchainComplete check for onParseBlockChainComplete before calling onParseBlockChainComplete to avoid duplicated calls of onParseBlockChainComplete. Happened if there was only one seed node.
Refactor dao state monitor domain. Add support for requesting all hashed from genesis from a peer which is in conflict (can help to find at which block the issue started).
|
Tested with DAO TESTNET and looks good so far:
|
- Add hashChain to snapshot - Use TreeMap instead of Map to have deterministic order - Use eventCoordinator to make correct order of execution transparent - Fix missing applying of nonBsqTxOutputMap at applySnapshot
sqrrm
reviewed
Mar 14, 2019
| @@ -45,9 +45,10 @@ | |||
| protected final long value; | |||
| protected final String txId; | |||
|
|
|||
| // Only set if dumpBlockchainData is true | |||
| // Before v0.9.6 it was only set if dumpBlockchainData was set to true but we changed that with 0.9.6 | |||
| // so that is is always set. We still need to support it because of backward compatibility. | |||
There was a problem hiding this comment.
Perhaps we should do a cleanup before starting testing on mainnet. That would break the regtestnet we have running now though.
core/src/main/java/bisq/core/dao/state/monitoring/DaoStateMonitoringService.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Monitors the DaoState with using a hash fo the complete daoState and make it accessible to the network for | ||
| * so we can detect quickly if any consensus issue arise. The data does not contain any private user | ||
| * data so sharing it on demand has no privacy concerns. |
There was a problem hiding this comment.
Could this be an attack vector, allowing too many requests as a DOS?
There was a problem hiding this comment.
On the P2P network level it would be disconnected it it gets heavy, but basically yes. We should consider to limit it somehow.
core/src/main/java/bisq/core/dao/state/monitoring/DaoStateMonitoringService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/dao/state/monitoring/DaoStateMonitoringService.java
Outdated
Show resolved
Hide resolved
core/src/main/java/bisq/core/dao/state/monitoring/DaoStateMonitoringService.java
Outdated
Show resolved
Hide resolved
- Move dao state monitor classes to other package structure - Add support for proposal payload monitor (WIP) - Use generics and sub classes for common functionality
- Cleanups - Improve logs
The setFitToRowsForTableView call at activate fixes the issue that the views sometimes do not render when changing views.
|
@sqrrm I think it is now complete. Could you cross check again? I tested re-orgs as well and seems that all works so far. Tested also backward compatibility with master and all ok. |
sqrrm
reviewed
Mar 16, 2019
core/src/main/java/bisq/core/dao/state/monitoring/DaoStateMonitoringService.java
Outdated
Show resolved
Hide resolved
- Change onDaoStateBlockChainChanged to onChangeAfterBatchProcessing to make it more clear that it is only called after parsing of blockchain is completed. - Change file name for DaoStateStore db file to DaoStateStore2 - Remove TODOs and outdated comments - Increase delay for broadcasting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sqrrm
Here is the current state:
It is still missing the p2p network data monitoring and tests with reorgs.