List bzedge #2603
Closed
List bzedge #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. Is everything ok with this PR? Let us know if there’s something more we have to do. |
|
There must be only one commit with proper commit message. |
See discussion at: bisq-network/proposals#75
We only want to show active bonds in the list for confiscation. The Inactive bond label is not necessary in the vote result as a confiscated bond is inactive anyway. Intention was probably to show it as inactive in the proposal display but they will be filtered out anyway there.
A Bisq trader suggested that change to cover risks with volatility for seller.
See discussion at #2547
Issue: When attempting to create an offer without a trading account for the selected currency, a prompt is shown asking the user whether to still create an offer or to create a new account. But this prompt is missing a cancel/close button in case you don't want to do either action. And pressing Esc on the keyboard proceeds to create the account. Cause: The close button on the prompt was renamed and being used to create a new account. Fix: Use the close button as a close button and add a secondary action button to create a new account. The popup width was increased to accommodate the long button text without being truncated.
…list of peers is provided.
Official project URL: https://getbze.com/ insight explorer : https://explorer.getbze.com/
sennevb
requested review from
cbeams,
ManfredKarrer and
ripcurlx
as code owners
|
seems i fucked up the rebase .. i needed to delete the branch, will open a new pull request.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Official project URL:
https://getbze.com/
insight explorer : https://explorer.getbze.com/