Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bitcoinj with connection handling audit fixes + Transaction.unCache() set confidence to null #2618

Merged

Conversation

oscarguindzberg
Copy link
Contributor

No description provided.

@oscarguindzberg
Copy link
Contributor Author

Not really "WIP", I assume we are using "WIP" for "Don't merge noncritical changes until further notice".

@ManfredKarrer
Copy link
Member

Yes its just a signal that not ready to merge. U can use the draft mode (dropdown when creating a PR) then it cannot be merged.

@ManfredKarrer
Copy link
Member

FYI we will delay all not DAO related PR after DAO launch.

@oscarguindzberg oscarguindzberg changed the title [WIP] Use bitcoinj with connection handling audit fixes. [WIP] Use bitcoinj with connection handling audit fixes + Transaction.unCache() set confidence to null May 9, 2019
@oscarguindzberg
Copy link
Contributor Author

Including latest bisq's bitcoinj commit "Transaction.unCache() set confidence to null"

@ManfredKarrer ManfredKarrer changed the title [WIP] Use bitcoinj with connection handling audit fixes + Transaction.unCache() set confidence to null Use bitcoinj with connection handling audit fixes + Transaction.unCache() set confidence to null May 14, 2019
Copy link
Member

@ManfredKarrer ManfredKarrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ManfredKarrer ManfredKarrer merged commit 405d4d0 into bisq-network:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants