[WIP] Delay payout if fiat buyer has new account #2765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…buyer-has-new-account
31 days was displayed as 31 day.
Implements bisq-network/proposals#77 If fiat trade the buyer need to have an min required account age, otherwise the payout will be delayed.
I think the features is now well known and can be removed. The account age check will add a nde popup so we would get more popup hell if we leave that one...
If offer maker for buying BTC with Fiat has an account selected which is less then the required account age for that method he gets a popup displayed.
ManfredKarrer
changed the title
|
The handling of the trade period warnings and time display is still missing... |
|
Another thing missing is an option for the seller as maker to accept or not accept younger accounts. We could add an option for min. account age for takers to an offer... |
m52go
reviewed
Apr 22, 2019
There was a problem hiding this comment.
Improved wording throughout.
Nitpick: I prefer this convention of using bitcoin for the currency and Bitcoin for the network.
ManfredKarrer
changed the title
# Conflicts: # desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/PendingTradesDataModel.java # desktop/src/main/java/bisq/desktop/main/portfolio/pendingtrades/steps/seller/SellerStep3View.java
Pure technical refactoring, no functionality change.
Move methods for delayed payout to AccountScore.
We use AccountScoreService as main class which constructs the parameters based on several protection tools. Currently there is only account age based protection.
|
Replaced by #2787 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has merged #2753 as some of those features are used.
Implements proposal bisq-network/proposals#77
Here are the relevant screens:
Create account:
Popup after account creation:
Popup at create buy offer:
Popup at take buy offer:
Popup at confirm fiat receipt:
Status while waiting until buyers account matures:
After buyers account has matured:
