Sign account usage #2768
Sign account usage #2768
Conversation
| // API | ||
| /////////////////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| // Arbitrators sign with EC key |
There was a problem hiding this comment.
Could you add a short explanation why arbitrators are using EC keys?
| .collect(Collectors.toSet()); | ||
| } | ||
|
|
||
| public boolean isValidAccountAgeWitness(AccountAgeWitness accountAgeWitness) { |
There was a problem hiding this comment.
There need to be a break in case of circular signing. If someone creates two witnesses that sign each other I think this recursion would go into an infinite loop.
There was a problem hiding this comment.
Hm... not sure if that can happen. Can you describe the case? If Alice signs Bob and Bob signs Carol and Carol signs Bob it is not an issue as the witness objects are the relevant objects which build the chain, not the signers. But in the lookup for the signers witness we need to probably use the date to use the oldest.
It also does not support yet handling of mulitple signers and when you are allowed to sign...
There was a problem hiding this comment.
Alice signs Bob's witness and Bob signs Alice's witness.
First level, trying to validaty Bob's witness, we find that it was signed by Alice. We then try to validate Alice's witness and during the second recursion we find that it's signed by Bob and will then try to validate it. Back to where we started in an infinite recursion.
Some leeway has to be given to the time stamps so an attack could be to create this pair and set the same date for both signedWitnesses.
I might well be missing something, and I don't think that's a risk during normal operation, just good to be safe and not add any attack vectors.
There was a problem hiding this comment.
I think we need to pass through the list and remove items once processed.
# Conflicts: # core/src/main/java/bisq/core/account/witness/AccountAgeWitnessService.java # desktop/src/main/java/bisq/desktop/components/PeerInfoIcon.java
|
Replaced by #2787 |
Implements bisq-network/proposals#78