Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle of envelopes #2939

Merged
merged 8 commits into from Jul 8, 2019

Conversation

@freimair
Copy link
Member

commented Jul 6, 2019

Seeing an oszillating pattern of broadcast message numbers in monitoring, @ManfredKarrer and I suspected that the pattern might be caused by the DoS protection mechanisms in place.

This PR introduces a new message that containing a number of existing messages. The hopes are:

  • less connection setup overhead on the network level leading to less network load and hopefully better performance
  • not to spread the bursts of e.g. RefreshOffer messages over a long time

In case this change has a bad effect on network stability (although we do not believe it is going to) we can simply remove the newly created Capability in a future release and thus, quickly get rid of the feature.

I tested the code extensively by running

  • 4 nodes locally
  • they knew each other as seed nodes
  • one of the nodes was connected to the live bisq network
  • had this setup running for days for each iteration

freimair added some commits Jun 24, 2019

@freimair freimair requested a review from ripcurlx as a code owner Jul 6, 2019

@freimair freimair changed the title Envelope of envelopes Bundle of envelopes Jul 8, 2019

@freimair freimair referenced this pull request Jul 8, 2019

@ripcurlx ripcurlx requested a review from sqrrm Jul 8, 2019

@sqrrm
Copy link
Member

left a comment

Seems like it's a bit risky, but not a bad idea. Need a bit more time to think on it.

freimair added some commits Jul 8, 2019

@ripcurlx

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Travis already ran through, but it is still showing pending. I'll merge it anyway.
@sqrrm If you find any issues with this implementation I'll revert this changes before the next release.

@ripcurlx ripcurlx merged commit 7b29511 into bisq-network:master Jul 8, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.