Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make rpc host configurable #2983

Merged
merged 1 commit into from Jul 22, 2019
Merged

make rpc host configurable #2983

merged 1 commit into from Jul 22, 2019

Conversation

mrosseel
Copy link
Member

What:

  • make the rpc host configurable
  • rename blockNotifyPort to rpcBlockPort
  • add information to log text on RpcService startup

Why:
when using docker (or different servers), the bitcoin full node and seednode run on different ip's.

@mrosseel mrosseel requested a review from ripcurlx as a code owner July 21, 2019 14:35
ripcurlx
ripcurlx reviewed Jul 22, 2019
View reviewed changes
Copy link
Member

@ripcurlx ripcurlx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ripcurlx ripcurlx merged commit 3b2484d into bisq-network:master Jul 22, 2019
@mrosseel mrosseel mentioned this pull request Jul 24, 2019
Closed
@ripcurlx ripcurlx mentioned this pull request Sep 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripcurlx ripcurlx ripcurlx left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrosseel @ripcurlx