Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 1896 #3009

Merged
merged 7 commits into from Aug 9, 2019

Conversation

@niyid
Copy link
Contributor

commented Jul 25, 2019

Removing references to deprecated DefaultAddressValidator.

  • 7 coins were affected: Counterparty, Decred, EtherClassic, Namecoin, Siafund, Unobtanium, Zcoin
  • EtherAddressValidator was extended to allow passing of i18n resource key.
  • Message resource entries for validation errors were added to displayStrings.properties.

fixes #1896

DefaultAddressValidator.
@niyid

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

Hi @ripcurlx,

As can be seen, I have created a new PR separately for issue 1896 as recommended.

Apologies for any inconvenience.

@niyid

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

I am just working on the build as project core which has the i18n resource class bisq.core.locale.Res is not set up as a dependency for project assets; rather core is a dependency for assets.

was created to load the properties file.

Unit Test components for touched coins fixed.
@niyid niyid requested a review from ripcurlx as a code owner Jul 25, 2019
Copy link
Member

left a comment

Ack. Although I have not tested any small detail...

@ManfredKarrer

This comment has been minimized.

Copy link
Member

commented Aug 6, 2019

@freimair Please use utACK in case you have not fully tested the PR...

@freimair freimair referenced this pull request Aug 9, 2019
@sqrrm sqrrm merged commit 1c5c633 into bisq-network:master Aug 9, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.