Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List VF CASH (VFC) #3066

Closed
wants to merge 5 commits into from
Closed

List VF CASH (VFC) #3066

wants to merge 5 commits into from

Conversation

vfcash
Copy link

@vfcash vfcash commented Aug 8, 2019

blabno
blabno suggested changes Aug 26, 2019
View reviewed changes
Copy link

@blabno blabno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK

assets/src/main/java/bisq/asset/coins/VFCASH.java
public class VFCASH extends Coin {

public VFCASH() {
super("VF CASH", "VFC", new DefaultAddressValidator());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not use deprecated validator.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the correct validator I should be using?

@ripcurlx
Copy link
Member

ripcurlx commented Oct 4, 2019

Closing because of inactivity for more than 30 days. Feel free to reopen if remarks from reviewer are taken into consideration.

@ripcurlx ripcurlx closed this Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blabno blabno blabno requested changes

Assignees
No one assigned
Labels
in:altcoins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vfcash @ripcurlx @blabno @freimair